[GitHub] [spark] cxzl25 commented on issue #23826: [SPARK-26914][SQL] Fix scheduler pool may be unpredictable when we only want to use default pool and do not set spark.scheduler.pool for the session

[GitBox <gi...@apache.org>]

cxzl25 commented on issue #23826: [SPARK-26914][SQL] Fix scheduler pool may be unpredictable when we only want to use default pool and do not set spark.scheduler.pool for the session
URL: https://github.com/apache/spark/pull/23826#issuecomment-478426671
 
 
   @srowen 
   I think this modification is a bit wrong. For example, when ```spark.sql.thriftServer.incrementalCollect=true```, ```getNextRowSet``` will resubmit the task. At this time, the schedule pool may be wrong.
   It should be ensured that the threadlocal variable is set before the method is executed, and cleared after execution.
   
   see https://github.com/apache/spark/pull/23895 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org