You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 09:50:49 UTC
[GitHub] [flink] aroch commented on a change in pull request #12008: [FLINK-14881] [s3|kinesis] Add support for IAM Roles for Service Accounts on AWS EKS
aroch commented on a change in pull request #12008:
URL: https://github.com/apache/flink/pull/12008#discussion_r425012028
##########
File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/AWSConfigConstants.java
##########
@@ -70,15 +73,18 @@
/** Optional configuration for profile name if credential provider type is set to be PROFILE. */
public static final String AWS_PROFILE_NAME = profileName(AWS_CREDENTIALS_PROVIDER);
- /** The role ARN to use when credential provider type is set to ASSUME_ROLE. */
+ /** The role ARN to use when credential provider type is set to ASSUME_ROLE or WEB_IDENTITY_TOKEN. */
public static final String AWS_ROLE_ARN = roleArn(AWS_CREDENTIALS_PROVIDER);
- /** The role session name to use when credential provider type is set to ASSUME_ROLE. */
+ /** The role session name to use when credential provider type is set to ASSUME_ROLE or WEB_IDENTITY_TOKEN. */
Review comment:
I saw there was no dedicated section for setting up access to Kinesis. I thought it makes sense to add a new section with some details.
I'm not a technical writer, so please let me know what you think :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org