You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "pellared (via GitHub)" <gi...@apache.org> on 2023/05/15 12:34:58 UTC
[GitHub] [thrift] pellared opened a new pull request, #2807: Fix NewTZlibTransportFactoryWithFactory comment
pellared opened a new pull request, #2807:
URL: https://github.com/apache/thrift/pull/2807
<!-- Explain the changes in the pull request below: -->
There is a bad name in the NewTZlibTransportFactoryWithFactory function comment.
Found here: https://github.com/open-telemetry/opentelemetry-go/pull/4020
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] pellared commented on pull request #2807: Fix NewTZlibTransportFactoryWithFactory comment
Posted by "pellared (via GitHub)" <gi...@apache.org>.
pellared commented on PR #2807:
URL: https://github.com/apache/thrift/pull/2807#issuecomment-1548319433
The build failures are not related to the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G merged pull request #2807: Fix NewTZlibTransportFactoryWithFactory comment
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #2807:
URL: https://github.com/apache/thrift/pull/2807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org