[GitHub] [kafka] cadonna commented on a diff in pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

[GitBox <gi...@apache.org>]

cadonna commented on code in PR #13014:
URL: https://github.com/apache/kafka/pull/13014#discussion_r1053065865


##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -650,12 +659,12 @@ private void produceValueRange(final int key, final int start, final int endExcl
     }
 
     private Properties streamsConfiguration() {
-        final String safeTestName = safeUniqueTestName(getClass(), testName);
+        final String safeTestName = safeUniqueTestName(getClass(), this.testInfo);

Review Comment:
   Instead of storing `testInfo` as field, you could store `applicationld` as field and compute the `applicationId` in `before()`. In such a way you only need to compute the `applicationId` once instead of twice for each test with two Streams clients.
   See https://github.com/apache/kafka/blob/c8675d4723a45d99aee6f64c6bf4703eeaea81aa/streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java#L124 for an example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org