You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/04 04:18:22 UTC
[PR] test(nameserver): cover blank and instance-scoped comparison inputs [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3097:
URL: https://github.com/apache/rocketmq-dashboard/pull/3097
### Summary
Cover the input normalization paths of `NameServerConfigDiffService` (complementary file to the drift tests):
- blank `clusterId` (and blank cluster on the instance overload) is rejected with the 400 `cluster is required`;
- the instance-scoped `compare` trims both ids and routes through the instance resolver (`getCluster(clusterId, instance)` + resolver execute);
- a blank instance id falls back to the unscoped two-argument lookup (and the no-endpoint 409).
### Why
The two public `compare` overloads normalize ids before lookup; locking the blank/instance behavior down prevents regressions in request routing.
### Testing
- `mvn -f server/pom.xml -Dtest=NameServerConfigDiffInputTest test` passes: 3/3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(nameserver): cover blank and instance-scoped comparison inputs [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3097: test(nameserver): cover blank and instance-scoped comparison inputs
URL: https://github.com/apache/rocketmq-dashboard/pull/3097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org