You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/02/21 14:28:42 UTC

[GitHub] flink pull request: [FLINK-3458] [build] Disable shade-flink execu...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1681

    [FLINK-3458] [build] Disable shade-flink execution in flink-shaded-hadoop

    The `shade-flink` execution of the parent pom caused the problem that the guava
    dependencies were relocated twice in the flink-shaded-hadoop jar. In order to
    avoid this, this patch disables the `shade-flink` execution.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixShading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1681
    
----
commit 834d352d62b1502d36bdf67d885fd874a70cb073
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-17T13:59:16Z

    [FLINK-3458] [build] Disable shade-flink execution in flink-shaded-hadoop
    
    The shade-flink execution of the parent pom caused the problem that the guava
    dependencies were relocated twice in the flink-shaded-hadoop jar. In order to
    avoid this, this patch disables the shade-flink execution.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3458] [build] Disable shade-flink execu...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1681


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3458] [build] Disable shade-flink execu...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1681#issuecomment-187265742
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3458] [build] Disable shade-flink execu...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1681#issuecomment-187604445
  
    Thanks for the review @rmetzger, @StephanEwen. Will merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3458] [build] Disable shade-flink execu...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1681#issuecomment-187107826
  
    +1 good catch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---