You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/03 02:42:45 UTC

[GitHub] [spark] LuciferYang edited a comment on pull request #34760: [SPARK-37506][CORE][SQL][DSTREAM][GRAPHX][ML][MLLIB][SS][EXAMPLES] Change the never changed 'var' to 'val'

LuciferYang edited a comment on pull request #34760:
URL: https://github.com/apache/spark/pull/34760#issuecomment-985165343


   > does it actually affect the performance BTW? I wonder if it's really worthwhile to sweep all these that would cause conflicts when backporting stuff.
   
   This does not seem to have a real performance impact, but the Scala language recommends that we use `val`, right? If we are worried about conflicts, I can give the corresponding PR to the required branch, do you think this is acceptable? @HyukjinKwon 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org