You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/21 10:47:46 UTC

[GitHub] [iotdb] SpriCoder commented on a change in pull request #5304: [IOTDB-2777][metrics]Fix NPE and sample frequency

SpriCoder commented on a change in pull request #5304:
URL: https://github.com/apache/iotdb/pull/5304#discussion_r830965729



##########
File path: server/src/main/java/org/apache/iotdb/db/service/IoTDB.java
##########
@@ -123,10 +123,10 @@ private void setUp() throws StartupException, QueryProcessException {
 
     Runtime.getRuntime().addShutdownHook(new IoTDBShutdownHook());
     setUncaughtExceptionHandler();
+    initServiceProvider();
     registerManager.register(MetricsService.getInstance());
     logger.info("recover the schema...");
     initSchemaEngine();
-    initServiceProvider();

Review comment:
       Why you move the place to init service Provider?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org