You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/12/01 09:21:14 UTC
Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1609
https://issues.apache.org/jira/browse/FALCON-1609
Repository: falcon-git
Description
-------
putting for early review
Diffs
-----
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
Diff: https://reviews.apache.org/r/40817/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java, line 118
> > <https://reviews.apache.org/r/40817/diff/1/?file=1149585#file1149585line118>
> >
> > nit: spacing between functions.
Will take care of all the checkstyle issues before posting to jira :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/#review110611
-----------------------------------------------------------
On Jan. 11, 2016, 3:32 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40817/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 3:32 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1609
> https://issues.apache.org/jira/browse/FALCON-1609
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> putting for early review
>
>
> Diffs
> -----
>
> cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
> cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
> cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java 8f3a2fc3ef57bb9026b98c85f51b363234d607c6
> cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
> cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
> client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
> client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952474fda1242f4b4b5a06ccfd3011ea533a
> client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
> client/src/main/java/org/apache/falcon/resource/EntityList.java f58169140af0f633463be93cff607c32e22254f4
>
> Diff: https://reviews.apache.org/r/40817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > Although there is base test class and test for FalconConnectionCommands, I didn't find any tests for EntityCommands. I am assuming it will be available in the final patch.
Yes. Just wanted someone to check the approach early on. Since the same approach will be used in the all of entity commands, instance commands etc. You haven't mentioned any issues with the approach, hence I'll go ahead.
I'm basically extracting commands, their options and their descriptions from the descriptions provided in the current CLI. Wherever required, I'm extracting `static final String` objects so that I can static import them in the new CLI. This will ensure that the two CLI's can co-exist with (almost) same commands. The co-existence period may(or not) be short, but I believe it's important for them to be in sync. And later when we want to deprecate the old CLI, we can just keep the `static final String` constants dumping everything else.
> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java, line 59
> > <https://reviews.apache.org/r/40817/diff/1/?file=1149586#file1149586line59>
> >
> > Why is this command required?
Don't worry about that, I'll remove it. So far it's just a WIP patch.
> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java, line 49
> > <https://reviews.apache.org/r/40817/diff/1/?file=1149587#file1149587line49>
> >
> > Is this complete list of EntityCommands? I couldn't find commands like entity defintion, hence wondering.
Not complete, Work in progress.
> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java, line 97
> > <https://reviews.apache.org/r/40817/diff/1/?file=1149591#file1149591line97>
> >
> > Where is this method used in the new framework?
It's not used.
> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java, line 55
> > <https://reviews.apache.org/r/40817/diff/1/?file=1149591#file1149591line55>
> >
> > nit: Validates an entity.
Just copied the old description. Guess that was wrong :)
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/#review110611
-----------------------------------------------------------
On Dec. 1, 2015, 1:51 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40817/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 1:51 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1609
> https://issues.apache.org/jira/browse/FALCON-1609
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> putting for early review
>
>
> Diffs
> -----
>
> cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
> cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
> cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
> cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
> client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
> client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
>
> Diff: https://reviews.apache.org/r/40817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/#review110611
-----------------------------------------------------------
Although there is base test class and test for FalconConnectionCommands, I didn't find any tests for EntityCommands. I am assuming it will be available in the final patch.
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java (line 117)
<https://reviews.apache.org/r/40817/#comment170563>
nit: spacing between functions.
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java (line 59)
<https://reviews.apache.org/r/40817/#comment170562>
Why is this command required?
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 49)
<https://reviews.apache.org/r/40817/#comment170569>
Is this complete list of EntityCommands? I couldn't find commands like entity defintion, hence wondering.
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 64)
<https://reviews.apache.org/r/40817/#comment170574>
Type of the entity. Valid entity types are: cluster, feed, process and datasource.
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 70)
<https://reviews.apache.org/r/40817/#comment170573>
Should be "Name of the entity, recommended but not mandatory to be unique."
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 48)
<https://reviews.apache.org/r/40817/#comment170564>
nit: Update an entity
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 53)
<https://reviews.apache.org/r/40817/#comment170565>
nit: Submits "an" entity
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 55)
<https://reviews.apache.org/r/40817/#comment170566>
nit: Validates an entity.
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 88)
<https://reviews.apache.org/r/40817/#comment170567>
Where is this method used in the new framework?
- Ajay Yadava
On Dec. 1, 2015, 8:21 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40817/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 8:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1609
> https://issues.apache.org/jira/browse/FALCON-1609
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> putting for early review
>
>
> Diffs
> -----
>
> cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
> cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
> cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
> cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
> client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
> client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
>
> Diff: https://reviews.apache.org/r/40817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 22, 2016, 1:50 p.m., Ajay Yadava wrote:
> > client/src/main/java/org/apache/falcon/resource/EntityList.java, line 55
> > <https://reviews.apache.org/r/40817/diff/3/?file=1192008#file1192008line55>
> >
> > This might affect other consumers of these fields. All of them might not show during compile time e.g. in regression code base they might be depending on these being static.
Enums are always static: http://stackoverflow.com/questions/23127926/static-enum-vs-non-static-enum
> On Jan. 22, 2016, 1:50 p.m., Ajay Yadava wrote:
> > cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java, line 47
> > <https://reviews.apache.org/r/40817/diff/3/?file=1192003#file1192003line47>
> >
> > no tests for Entity Commands?
Current Client has no tests, if I were to add tests, I'd be adding tests for the shell mocking the client.
> On Jan. 22, 2016, 1:50 p.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java, line 239
> > <https://reviews.apache.org/r/40817/diff/3/?file=1192000#file1192000line239>
> >
> > why is ENTITY_PREFIX required for validating orderBy?
Existing design, it's already required.
> On Jan. 22, 2016, 1:50 p.m., Ajay Yadava wrote:
> > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java, line 81
> > <https://reviews.apache.org/r/40817/diff/3/?file=1192000#file1192000line81>
> >
> > 2 constants with same value, 1 can't be used in all places?
Not the same value. one is "entity", another is "entity "
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/#review115636
-----------------------------------------------------------
On Jan. 11, 2016, 5:02 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40817/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 5:02 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1609
> https://issues.apache.org/jira/browse/FALCON-1609
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> putting for early review
>
>
> Diffs
> -----
>
> cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
> cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
> cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java 8f3a2fc3ef57bb9026b98c85f51b363234d607c6
> cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
> cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
> client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
> client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952474fda1242f4b4b5a06ccfd3011ea533a
> client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
> client/src/main/java/org/apache/falcon/resource/EntityList.java f58169140af0f633463be93cff607c32e22254f4
>
> Diff: https://reviews.apache.org/r/40817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/#review115636
-----------------------------------------------------------
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java (line 44)
<https://reviews.apache.org/r/40817/#comment176623>
Just curious, why is it required?
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java (line 33)
<https://reviews.apache.org/r/40817/#comment176624>
Hmm.. so our checkstyle allows wildcard imports for static members?
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 45)
<https://reviews.apache.org/r/40817/#comment176872>
required?
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 81)
<https://reviews.apache.org/r/40817/#comment176873>
2 constants with same value, 1 can't be used in all places?
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 86)
<https://reviews.apache.org/r/40817/#comment176630>
If I recall correctly not all of these parameters are mandatory.
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 109)
<https://reviews.apache.org/r/40817/#comment176861>
I think it should have been a String instead of File
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 117)
<https://reviews.apache.org/r/40817/#comment176862>
I believe this method should have been called update
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 206)
<https://reviews.apache.org/r/40817/#comment176866>
nit: should we rename ENTITY_PREFIX_SPACE to ENTITY_COMMAND_PREFIX or ENTITY_PREFIX? Will that be a misrepresentation?
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 239)
<https://reviews.apache.org/r/40817/#comment176874>
why is ENTITY_PREFIX required for validating orderBy?
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 248)
<https://reviews.apache.org/r/40817/#comment176870>
I think we should be able to directly write it as final EntityType type instead of final String entityType.
If yes, then please make that change for all commands.
cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java (line 47)
<https://reviews.apache.org/r/40817/#comment176871>
no tests for Entity Commands?
client/src/main/java/org/apache/falcon/resource/EntityList.java (line 55)
<https://reviews.apache.org/r/40817/#comment176875>
This might affect other consumers of these fields. All of them might not show during compile time e.g. in regression code base they might be depending on these being static.
- Ajay Yadava
On Jan. 11, 2016, 11:32 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40817/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 11:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1609
> https://issues.apache.org/jira/browse/FALCON-1609
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> putting for early review
>
>
> Diffs
> -----
>
> cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
> cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
> cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
> cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
> cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java 8f3a2fc3ef57bb9026b98c85f51b363234d607c6
> cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
> cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
> client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
> client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952474fda1242f4b4b5a06ccfd3011ea533a
> client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
> client/src/main/java/org/apache/falcon/resource/EntityList.java f58169140af0f633463be93cff607c32e22254f4
>
> Diff: https://reviews.apache.org/r/40817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 5:02 p.m.)
Review request for Falcon.
Bugs: FALCON-1609
https://issues.apache.org/jira/browse/FALCON-1609
Repository: falcon-git
Description
-------
putting for early review
Diffs (updated)
-----
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java 8f3a2fc3ef57bb9026b98c85f51b363234d607c6
cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952474fda1242f4b4b5a06ccfd3011ea533a
client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
client/src/main/java/org/apache/falcon/resource/EntityList.java f58169140af0f633463be93cff607c32e22254f4
Diff: https://reviews.apache.org/r/40817/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40817: FALCON-1609: Add entity commands to falcon
spring-shell CLI
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40817/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 3:32 p.m.)
Review request for Falcon.
Bugs: FALCON-1609
https://issues.apache.org/jira/browse/FALCON-1609
Repository: falcon-git
Description
-------
putting for early review
Diffs (updated)
-----
cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java b7fa4cd524bfcd50ac260dadc2a1f94021b3df03
cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0
cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java cabe5a8083daf90456636d3378e410e3d95a4ada
cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java 6e091efcbe26ff7df7a3fe52e33b20f781b8d785
cli/src/main/java/org/apache/falcon/cli/commands/FalconInstanceCommands.java 8f3a2fc3ef57bb9026b98c85f51b363234d607c6
cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java PRE-CREATION
cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java PRE-CREATION
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230ae66ba710945be76d176fbdbdbbcb3721c
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java cb39a2fe95beae32dee930afb9bb78d85ebb58ea
client/src/main/java/org/apache/falcon/client/FalconCLIException.java 51ef952474fda1242f4b4b5a06ccfd3011ea533a
client/src/main/java/org/apache/falcon/client/FalconClient.java b4b176224554fb5a86ebca2bcced980dc84d2dd6
client/src/main/java/org/apache/falcon/resource/EntityList.java f58169140af0f633463be93cff607c32e22254f4
Diff: https://reviews.apache.org/r/40817/diff/
Testing
-------
Thanks,
Rajat Khandelwal