You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/05/07 16:30:20 UTC
Review Request 21160: Usability: performing connectivity checks against an
external database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
Review request for Ambari and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs
-----
ambari-server/pom.xml 5b465eb
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/#review42411
-----------------------------------------------------------
Ship it!
LGTM
- Dmitro Lisnichenko
On May 7, 2014, 4:47 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21160/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 4:47 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
>
>
> Bugs: AMBARI-5696
> https://issues.apache.org/jira/browse/AMBARI-5696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
> When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
> API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml 5b465eb
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificatorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21160/diff/
>
>
> Testing
> -------
>
> Listening for transport dt_socket at address: 5007
> Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
>
> Results :
>
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/#review43742
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On May 22, 2014, 6 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21160/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 6 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
>
>
> Bugs: AMBARI-5696
> https://issues.apache.org/jira/browse/AMBARI-5696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
> When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
> API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/check_host.py 19628e2
>
> Diff: https://reviews.apache.org/r/21160/diff/
>
>
> Testing
> -------
>
> Listening for transport dt_socket at address: 5007
> Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
>
> Results :
>
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/#review43930
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On May 26, 2014, 1:34 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21160/
> -----------------------------------------------------------
>
> (Updated May 26, 2014, 1:34 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
>
>
> Bugs: AMBARI-5696
> https://issues.apache.org/jira/browse/AMBARI-5696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
> When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
> API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 81dadbd
> ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
> ambari-server/src/test/python/TestAmbariServer.py 3817e91
>
> Diff: https://reviews.apache.org/r/21160/diff/
>
>
> Testing
> -------
>
> Listening for transport dt_socket at address: 5007
> Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
>
> Results :
>
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/#review43929
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On May 26, 2014, 1:34 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21160/
> -----------------------------------------------------------
>
> (Updated May 26, 2014, 1:34 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
>
>
> Bugs: AMBARI-5696
> https://issues.apache.org/jira/browse/AMBARI-5696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
> When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
> API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 81dadbd
> ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
> ambari-server/src/test/python/TestAmbariServer.py 3817e91
>
> Diff: https://reviews.apache.org/r/21160/diff/
>
>
> Testing
> -------
>
> Listening for transport dt_socket at address: 5007
> Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
>
> Results :
>
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/#review44124
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On May 28, 2014, 4:10 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21160/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 4:10 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
>
>
> Bugs: AMBARI-5696
> https://issues.apache.org/jira/browse/AMBARI-5696
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
> When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
> API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py e96deb5
> ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py ed74232
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java e5c5ca8
> ambari-server/src/main/python/ambari-server.py aa183e8
> ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
> ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java e3575e1
> ambari-server/src/test/python/TestAmbariServer.py 3817e91
> ambari-server/src/test/python/TestCheckHost.py e40dee3
>
> Diff: https://reviews.apache.org/r/21160/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [5.824s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.794s]
> [INFO] Ambari Web ........................................ SUCCESS [14.285s]
> [INFO] Ambari Views ...................................... SUCCESS [4.946s]
> [INFO] Ambari Server ..................................... SUCCESS [31:01.333s]
> [INFO] Ambari Agent ...................................... SUCCESS [11.715s]
> [INFO] Ambari Client ..................................... SUCCESS [1.332s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.724s
> [INFO] Finished at: Wed May 28 19:04:47 FET 2014
> [INFO] Final Memory: 23M/183M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 28, 2014, 4:10 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py e96deb5
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py ed74232
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java e5c5ca8
ambari-server/src/main/python/ambari-server.py aa183e8
ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java e3575e1
ambari-server/src/test/python/TestAmbariServer.py 3817e91
ambari-server/src/test/python/TestCheckHost.py e40dee3
Diff: https://reviews.apache.org/r/21160/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [5.824s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.794s]
[INFO] Ambari Web ........................................ SUCCESS [14.285s]
[INFO] Ambari Views ...................................... SUCCESS [4.946s]
[INFO] Ambari Server ..................................... SUCCESS [31:01.333s]
[INFO] Ambari Agent ...................................... SUCCESS [11.715s]
[INFO] Ambari Client ..................................... SUCCESS [1.332s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:41.724s
[INFO] Finished at: Wed May 28 19:04:47 FET 2014
[INFO] Final Memory: 23M/183M
[INFO] ------------------------------------------------------------------------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 28, 2014, 4:10 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py e96deb5
ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py ed74232
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java e5c5ca8
ambari-server/src/main/python/ambari-server.py aa183e8
ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java e3575e1
ambari-server/src/test/python/TestAmbariServer.py 3817e91
ambari-server/src/test/python/TestCheckHost.py e40dee3
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 27, 2014, 5:35 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
Changes
-------
Final patch, with tests and fix for RootServiceComponents.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java e5c5ca8
ambari-server/src/main/python/ambari-server.py 81dadbd
ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
ambari-server/src/test/python/TestAmbariServer.py 3817e91
ambari-server/src/test/python/TestCheckHost.py e40dee3
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 26, 2014, 1:34 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py 81dadbd
ambari-server/src/main/resources/custom_actions/check_host.py 6ed0b31
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 43f375d
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/shared_initialization.py ff3e818
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py 39eef3b
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 861ed55
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py 2c0d1b1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py a65473d
ambari-server/src/test/python/TestAmbariServer.py 3817e91
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 26, 2014, 1:34 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Mahadev Konar.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs
-----
ambari-server/src/main/python/ambari-server.py 81dadbd
ambari-server/src/main/resources/custom_actions/check_host.py e5aa920
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 23, 2014, 2:33 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
Changes
-------
Second part of changes! Please review it. Ticket for tests i'll create later.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs
-----
ambari-server/src/main/python/ambari-server.py 81dadbd
ambari-server/src/main/resources/custom_actions/check_host.py e5aa920
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 23, 2014, 2:32 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py 81dadbd
ambari-server/src/main/resources/custom_actions/check_host.py e5aa920
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 22, 2014, 6 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/src/main/resources/custom_actions/check_host.py 19628e2
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 22, 2014, 5:46 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/src/main/resources/custom_actions/check_host.py 19628e2
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 7, 2014, 4:47 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/pom.xml 5b465eb
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 7, 2014, 4:45 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs
-----
ambari-server/pom.xml 5b465eb
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/21160/diff/
Testing (updated)
-------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.view.RemoteDBConnectionVerificator.RemoteDBConnectionVerificatorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.247 sec
Results :
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 7, 2014, 4:44 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Changes
-------
Tests were added
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs (updated)
-----
ambari-server/pom.xml 5b465eb
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 21160: Usability: performing connectivity checks against
an external database
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21160/
-----------------------------------------------------------
(Updated May 7, 2014, 2:31 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
Bugs: AMBARI-5696
https://issues.apache.org/jira/browse/AMBARI-5696
Repository: ambari
Description
-------
Hive/Oozie (and possibly other components in the future) make use of a relational database to store its metadata.
When the user wants to use an existing, external database, it's easy to mistype the credentials/JDBC string. Currently, such mistakes are not caught until service install or start, at which point it's a pain to reconfigure and fix the issue.
API should expose the ability to check database connectivity given the JDBC connection string, username, and password, so that the UI can expose this to the end user in the Customize Services page.
Diffs
-----
ambari-server/pom.xml 5b465eb
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/RemoteDBConnectionVerificator.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/RemoteDBConnectionVerificator/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/21160/diff/
Testing
-------
Thanks,
Vitalyi Brodetskyi