You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by GitBox <gi...@apache.org> on 2017/11/27 10:08:28 UTC
[GitHub] charlesccychen commented on a change in pull request #4136: [BEAM-3184] Added ProxyInfoFromEnvironmentVar() & GetNewHttp() methods for GCS
charlesccychen commented on a change in pull request #4136: [BEAM-3184] Added ProxyInfoFromEnvironmentVar() & GetNewHttp() methods for GCS
URL: https://github.com/apache/beam/pull/4136#discussion_r153152130
##########
File path: sdks/python/apache_beam/io/gcp/gcsio.py
##########
@@ -87,6 +87,50 @@
MAX_BATCH_OPERATION_SIZE = 100
+def ProxyInfoFromEnvironmentVar(proxy_env_var):
Review comment:
<!--new_thread; commit:a648a0224e9c7cc59c6d65ae14b03e07ee1e2171; resolved:0-->
Please use PEP8 function names thoughout (https://www.python.org/dev/peps/pep-0008/#function-names).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services