[GitHub] cloud-fan commented on a change in pull request #23196: [SPARK-26243][SQL] Use java.time API for parsing timestamps and dates from JSON

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23196: [SPARK-26243][SQL] Use java.time API for parsing timestamps and dates from JSON
URL: https://github.com/apache/spark/pull/23196#discussion_r241253585
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
 ##########
 @@ -77,6 +77,12 @@ private[sql] class JacksonGenerator(
 
   private val lineSeparator: String = options.lineSeparatorInWrite
 
+  private val timeFormatter = DateTimeFormatter(
 
 Review comment:
   `timestampFormatter`, `time` is a different type in SQL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org