You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2025/03/14 14:24:22 UTC

[PR] Fix 'setup-zk' bash syntax error [solr-operator]

gerlowskija opened a new pull request, #769:
URL: https://github.com/apache/solr-operator/pull/769

   Mismatched brackets were causing the 'grep' portion of the conditional to report an error when triggered.
   
   Fixes #759 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Fix 'setup-zk' bash syntax error [solr-operator]

Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2730254419

   "Spellcheck" or "[ShellCheck](https://github.com/koalaman/shellcheck)"?
   
   Assuming you mean "ShellCheck", but I'm not too familiar with it.  Seems like a good thing to have analysis on generally - our unit tests validate that the container "command" looks the way we expect, but nothing ever really ensures that it's even valid bash 😦 
   
   Thanks for the pointer; will take a look and file a follow-on ticket if it seems promising!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Fix 'setup-zk' bash syntax error [solr-operator]

Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #769:
URL: https://github.com/apache/solr-operator/pull/769


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Fix 'setup-zk' bash syntax error [solr-operator]

Posted by "madrob (via GitHub)" <gi...@apache.org>.
madrob commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2725303749

   I would consider pulling the entire scriptlets into separate files and then you can run spellcheck on those?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Fix 'setup-zk' bash syntax error [solr-operator]

Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2725240241

   I think our existing testing (see `tests/e2e/solrcloud_security_json_test.go`) is sufficient here.  It never caught the #759 error, because it's not actually an error ("just" some noise in the logs)!
   
   `grep -q` does print a message to stderr, but it doesn't impact the return status of the `grep` call, which returns zero/non-zero based on whether it finds a match in `/tmp/current_security.json`.  `grep` doesn't care that you also asked it to search other files (i.e. `]`) that don't exist.  So despite the syntax error, the overall conditional still operated as we wanted it to.
   
   We could add an additional test case to `solrcloud_security_json_test.go`, to cover the case of a security.json file whose contents are `{}`, but IMO that edgecase is rare enough that it's not worth bloating the runtime of our e2e tests.
   
   If anyone disagrees though, lmk and I'll add it in.  Otherwise, I'll probably target early next week to merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] Fix 'setup-zk' bash syntax error [solr-operator]

Posted by "madrob (via GitHub)" <gi...@apache.org>.
madrob commented on PR #769:
URL: https://github.com/apache/solr-operator/pull/769#issuecomment-2730457223

   Yes, shellcheck. Auto-correct got me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org