You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/05 11:49:13 UTC
[GitHub] [incubator-doris-spark-connector] cxzl25 opened a new pull request, #24: [feature] Support Spark3.2 compilation
cxzl25 opened a new pull request, #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24
# Proposed changes
Issue Number: close #23
## Problem Summary:
Support using Spark3.2 version to compile and test
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] cxzl25 commented on a diff in pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24#discussion_r865822030
##########
spark-doris-connector/pom.xml:
##########
@@ -132,6 +134,12 @@
</profile>
</profiles>
<dependencies>
+ <dependency>
Review Comment:
`netty-all` needs to be in front of `arrow-memory-netty`, because `arrow-memory-netty` introduces the `netty-buffer` version, and the wrong version will be loaded during test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] hf200012 commented on a diff in pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
hf200012 commented on code in PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24#discussion_r867280192
##########
spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java:
##########
@@ -44,14 +44,13 @@
import org.apache.doris.spark.rest.models.Schema;
import org.apache.doris.spark.rest.models.Tablet;
import org.junit.Assert;
+import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import jdk.nashorn.internal.ir.annotations.Ignore;
Review Comment:
@cxzl25 Add me WeChat: 35926237, there is a problem with your compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] cxzl25 commented on pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24#issuecomment-1118459524
```bash
mvn clean package -Dspark.version=3.2.0 -Dscala.version=2.12 -Dspark.minor.version=3.2 -Dnetty.version=4.1.68.Final -Dfasterxml.jackson.version=2.12.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] hf200012 merged pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
hf200012 merged PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] hf200012 commented on pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
hf200012 commented on PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24#issuecomment-1120093867
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project spark-doris-connector-3.2_2.12: Compilation failure: Compilation failure:
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[75,28] 程序包org.codehaus.jackson不存在
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[76,32] 程序包org.codehaus.jackson.map不存在
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[77,32] 程序包org.codehaus.jackson.map不存在
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[141,17] 找不到符号
[ERROR] 符号: 类 ObjectMapper
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[141,43] 找不到符号
[ERROR] 符号: 类 ObjectMapper
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[292,9] 找不到符号
[ERROR] 符号: 类 ObjectMapper
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[292,35] 找不到符号
[ERROR] 符号: 类 ObjectMapper
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[296,18] 找不到符号
[ERROR] 符号: 类 JsonParseException
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[300,18] 找不到符号
[ERROR] 符号: 类 JsonMappingException
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[370,9] 找不到符号
[ERROR] 符号: 类 ObjectMapper
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[370,35] 找不到符号
[ERROR] 符号: 类 ObjectMapper
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[374,18] 找不到符号
[ERROR] 符号: 类 JsonParseException
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] /mnt/disk1/jiafeng/incubator-doris-spark-connector/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java:[378,18] 找不到符号
[ERROR] 符号: 类 JsonMappingException
[ERROR] 位置: 类 org.apache.doris.spark.rest.RestService
[ERROR] -> [Help 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] cxzl25 commented on a diff in pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24#discussion_r865823571
##########
spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java:
##########
@@ -44,14 +44,13 @@
import org.apache.doris.spark.rest.models.Schema;
import org.apache.doris.spark.rest.models.Tablet;
import org.junit.Assert;
+import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import jdk.nashorn.internal.ir.annotations.Ignore;
Review Comment:
JDK11 removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris-spark-connector] smallhibiscus commented on a diff in pull request #24: [feature] Support Spark3.2 compilation
Posted by GitBox <gi...@apache.org>.
smallhibiscus commented on code in PR #24:
URL: https://github.com/apache/incubator-doris-spark-connector/pull/24#discussion_r867318554
##########
spark-doris-connector/pom.xml:
##########
@@ -132,6 +134,12 @@
</profile>
</profiles>
<dependencies>
+ <dependency>
Review Comment:
spark-core has introduced netty-all dependency, no need to add it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org