[jira] [Updated] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

["Cody Schafer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cody Schafer updated THRIFT-3828:
---------------------------------
    Attachment: 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch

> cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty 
> ---------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3828
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3828
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Cody Schafer
>            Priority: Minor
>         Attachments: 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch
>
>
> This is due to the current quoting of those variables when passed to `include_directories()`. These variables may (and soon will, see below) be empty in the case where the include directory is a system include path that is implicitly included.
> I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't work with includes that are part of the platform/system include path (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types of directories to Boost_INCLUDE_DIRS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)