You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/22 14:17:30 UTC
[GitHub] [incubator-pekko] pjfanning opened a new issue, #326: link validator check broken by license-report
pjfanning opened a new issue, #326:
URL: https://github.com/apache/incubator-pekko/issues/326
Not urgent. Just spotted the broken CI job.
https://github.com/apache/incubator-pekko/actions/runs/5042361658
fyi @mdedetrich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #326: link validator check broken by license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #326:
URL: https://github.com/apache/incubator-pekko/issues/326#issuecomment-1559912672
After checking both the example [application.conf](https://github.com/ennru/site-link-validator/blob/master/core/src/main/resources/application.conf) and the [source-code](https://github.com/ennru/site-link-validator/blob/d8fa59afbe2228115868bb88d145e7578ae7e5fa/core/src/main/scala/net/runne/sitelinkvalidator/Main.scala#L68) I can't seem to find any such config.
Ill manually add the links for know, its a bit annoying but we only need to do it once and the dependencies don't get updated that often anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich closed issue #326: link validator check broken by license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #326: link validator check broken by license-report
URL: https://github.com/apache/incubator-pekko/issues/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #326: link validator check broken by license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #326:
URL: https://github.com/apache/incubator-pekko/issues/326#issuecomment-1559901387
Ah I see the issue now, sbt-license-report is putting links in the report that are derived from the pom fields in the transitive dependencies. Some of those fields are only http, so a low hanging fruit improvement can be enabling http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #326: link validator check broken by license-report
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #326:
URL: https://github.com/apache/incubator-pekko/issues/326#issuecomment-1559905713
is it possible to get link-validator to skip this file altogether?
Then we can validate only https is used in our main pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #326: link validator check broken by license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #326:
URL: https://github.com/apache/incubator-pekko/issues/326#issuecomment-1557324600
I just did a quick cursory look and aside from the link validator failing due to docs not being fully fixed (which is expected) it appears to also fail if use non https links, i.e.
```
* Failure responses found.
* Non-https URLs found (configure `non-https-accepted` if needed).
Error: Process completed with exit code 255.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org