You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "luoyuxia (via GitHub)" <gi...@apache.org> on 2025/08/11 06:20:20 UTC
[PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
luoyuxia opened a new pull request, #1520:
URL: https://github.com/apache/fluss/pull/1520
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/alibaba/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #1379
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on PR #1520:
URL: https://github.com/apache/fluss/pull/1520#issuecomment-3225333915
LGTM aswell, thanks for taking care of it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #1520:
URL: https://github.com/apache/fluss/pull/1520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
Posted by "MehulBatra (via GitHub)" <gi...@apache.org>.
MehulBatra commented on PR #1520:
URL: https://github.com/apache/fluss/pull/1520#issuecomment-3225289171
> LGTM!
>
> What `substasks` do you mean by `I'd like to merge it after all other substasks merged`?
@wuchong
I believe @luoyuxia meant to merge this, post we get done with all the sub-taks under umbrella feature #452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1520:
URL: https://github.com/apache/fluss/pull/1520#discussion_r2296997943
##########
fluss-lake/fluss-lake-iceberg/pom.xml:
##########
@@ -227,6 +227,56 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <!-- compilation of main sources -->
+ <skipMain>${skip.on.java8}</skipMain>
+ <!-- compilation of test sources -->
+ <skip>${skip.on.java8}</skip>
Review Comment:
The configuration skips compilation on Java 8, but the PR description states the goal is to support compilation with JDK 8. This appears contradictory - if Iceberg 1.9.1 is chosen specifically for JDK 8 compatibility, the build should not skip compilation on Java 8.
```suggestion
<!-- Removed skipMain to allow compilation on Java 8 -->
<!-- compilation of test sources -->
<!-- Removed skip to allow test compilation on Java 8 -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #1520:
URL: https://github.com/apache/fluss/pull/1520#issuecomment-3173468267
I'd like to merge it after all other substasks merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [iceberg] Upgrade iceberg version to 1.9.1 [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #1520:
URL: https://github.com/apache/fluss/pull/1520#issuecomment-3226411560
> LGTM!
>
> What `substasks` do you mean by `I'd like to merge it after all other substasks merged`?
When I fire this pr, there still reamin many subtasks are working. I'm afraid of there are some conflicts. But we almost get all to finish. So I'd like to merge it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org