You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/10/05 08:43:13 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8923: Do not send zoneId with ...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/911
CLOUDSTACK-8923: Do not send zoneId with createStorageNetworkIpRange command.
The zoneId was send with the createStorageNetworkIpRange from the wizard. This isn't necessary. It will only remove the warning. It doesn't fix the transaction issue from CLOUDSTACK-8923 itself.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8923
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/911.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #911
----
commit 9f4eb414282a5069481f633d502b1ee405083536
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-10-05T06:41:12Z
CLOUDSTACK-8923: Do not send zoneId with createStorageNetworkIpRange command.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8923: Do not send zoneId with ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/911#issuecomment-146866664
Hi @borisroman any update on this? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8923: Do not send zoneId with ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/911#discussion_r41118074
--- Diff: server/src/com/cloud/network/StorageNetworkManagerImpl.java ---
@@ -223,7 +225,7 @@ public StorageNetworkIpRange createIpRange(final CreateStorageNetworkIpRangeCmd
checkOverlapPrivateIpRange(podId, startIp, endIp);
checkOverlapStorageIpRange(podId, startIp, endIp);
- StorageNetworkIpRangeVO range = null;
+ //StorageNetworkIpRangeVO range = null;
--- End diff --
I know :) Still busy testing, please read the last comment of my PR message. I PR'd the first commit, then pushed the second one for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8923: Do not send zoneId with ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/911
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8923: Do not send zoneId with ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/911#discussion_r41117252
--- Diff: server/src/com/cloud/network/StorageNetworkManagerImpl.java ---
@@ -223,7 +225,7 @@ public StorageNetworkIpRange createIpRange(final CreateStorageNetworkIpRangeCmd
checkOverlapPrivateIpRange(podId, startIp, endIp);
checkOverlapStorageIpRange(podId, startIp, endIp);
- StorageNetworkIpRangeVO range = null;
+ //StorageNetworkIpRangeVO range = null;
--- End diff --
please don't comment out code, remove it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---