You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by im...@apache.org on 2008/02/21 17:33:23 UTC
svn commit: r629855 -
/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/inputsuggestajax/InputSuggestAjaxRenderer.java
Author: imario
Date: Thu Feb 21 08:33:22 2008
New Revision: 629855
URL: http://svn.apache.org/viewvc?rev=629855&view=rev
Log:
fixed rendering the hidden field with labelMethod even if value is null
Modified:
myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/inputsuggestajax/InputSuggestAjaxRenderer.java
Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/inputsuggestajax/InputSuggestAjaxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/inputsuggestajax/InputSuggestAjaxRenderer.java?rev=629855&r1=629854&r2=629855&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/inputsuggestajax/InputSuggestAjaxRenderer.java (original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/suggestajax/inputsuggestajax/InputSuggestAjaxRenderer.java Thu Feb 21 08:33:22 2008
@@ -85,6 +85,7 @@
String label = null;
String hiddenInputValue = null;
+ boolean hasLabelMethod = false;
String mainComponentRenderedValue = null;
@@ -99,6 +100,8 @@
if (labelMethod != null)
{
+ hasLabelMethod = true;
+
Object valueObject = inputSuggestAjax.getValue();
Converter converter = getRequiredConverter(context, inputSuggestAjax);
@@ -107,7 +110,6 @@
hiddenInputValue = converter.getAsString(context, inputSuggestAjax, valueObject);
mainComponentRenderedValue = hiddenInputValue;
-
}
}
@@ -190,13 +192,13 @@
out.endElement(HTML.SCRIPT_ELEM);
- if (hiddenInputValue != null)
+ if (hasLabelMethod)
{
out.startElement(HTML.INPUT_ELEM, inputSuggestAjax);
out.writeAttribute(HTML.TYPE_ATTR, HTML.INPUT_TYPE_HIDDEN, null);
out.writeAttribute(HTML.ID_ATTR, clientId, null);
out.writeAttribute(HTML.NAME_ATTR, clientId, null);
- out.writeAttribute(HTML.VALUE_ATTR, hiddenInputValue, null);
+ out.writeAttribute(HTML.VALUE_ATTR, hiddenInputValue!=null?hiddenInputValue:"", null);
out.endElement(HTML.INPUT_ELEM);
out.startElement(HTML.SCRIPT_ELEM, null);