You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/10 10:45:23 UTC

[GitHub] [hadoop] steveloughran commented on a change in pull request #2205: HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false

steveloughran commented on a change in pull request #2205:
URL: https://github.com/apache/hadoop/pull/2205#discussion_r467821964



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemLinkFallback.java
##########
@@ -759,7 +759,11 @@ public void testMkdirsShouldReturnFalseWhenFallbackFSNotAvailable()
       cluster.shutdownNameNodes(); // Stopping fallback server
       // /user1/test1 does not exist in mount internal dir tree, it would
       // attempt to create in fallback.
-      assertFalse(vfs.mkdirs(nextLevelToInternalDir));
+      try {
+        vfs.mkdirs(nextLevelToInternalDir);

Review comment:
       Use LambdaTestUtils.intercept()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org