You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/05/15 10:27:30 UTC
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
-----------------------------------------------------------
(Updated May 15, 2017, 12:27 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364
Repository: mesos
Description
-------
This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.
Diffs (updated)
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
Diff: https://reviews.apache.org/r/58349/diff/3/
Changes: https://reviews.apache.org/r/58349/diff/2-3/
Testing (updated)
-------
make check (on macOS, Linux, Windows)
Don't commit without 58350 and 58351.
Thanks,
Jan Schlicht
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/#review175283
-----------------------------------------------------------
3rdparty/Makefile.am
Line 48 (original), 48 (patched)
<https://reviews.apache.org/r/58349/#comment248731>
This should be `$(GOOGLETEST_VERSION)`, for local consistency -- I fixed in a separate commit.
- Neil Conway
On May 17, 2017, 10 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58349/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 10 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7364
> https://issues.apache.org/jira/browse/MESOS-7364
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will fix various issues that occured with version 1.7.0.
> As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
> test cases have been updated accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
> 3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
> 3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
> 3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
> 3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
> 3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
> LICENSE 512b089c5dd2540f9f83afb559e5d0998d97ea22
> configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
> src/Makefile.am 1522c5b6fbd9cff4581f963716b131320e254373
> src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
> src/tests/containerizer/linux_capabilities_isolator_tests.cpp f9d2a532bb5bef4654474cb171911952218780fa
> src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
> src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
> src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
> support/mesos-style.py 53ffe3b080f50924acc8bffe66c47f15b4ea85af
> support/mesos-tidy/entrypoint.sh 5dbaa6086621934a7313dfa5c8008b6a6f5496f1
>
>
> Diff: https://reviews.apache.org/r/58349/diff/5/
>
>
> Testing
> -------
>
> Tested in https://reviews.apache.org/r/58351/
>
> Don't commit without 58350 and 58351.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
-----------------------------------------------------------
(Updated May 17, 2017, noon)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Addressed issues, removed wrong `glog` entry in `Versions.cmake`.
Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364
Repository: mesos
Description
-------
This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.
Diffs (updated)
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
LICENSE 512b089c5dd2540f9f83afb559e5d0998d97ea22
configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
src/Makefile.am 1522c5b6fbd9cff4581f963716b131320e254373
src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
src/tests/containerizer/linux_capabilities_isolator_tests.cpp f9d2a532bb5bef4654474cb171911952218780fa
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
support/mesos-style.py 53ffe3b080f50924acc8bffe66c47f15b4ea85af
support/mesos-tidy/entrypoint.sh 5dbaa6086621934a7313dfa5c8008b6a6f5496f1
Diff: https://reviews.apache.org/r/58349/diff/5/
Changes: https://reviews.apache.org/r/58349/diff/4-5/
Testing
-------
Tested in https://reviews.apache.org/r/58351/
Don't commit without 58350 and 58351.
Thanks,
Jan Schlicht
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On May 17, 2017, 1:35 a.m., Neil Conway wrote:
> > There are more `tr1` references in `sorter_tests.cpp` -- can you fix these?
> >
> > See also earlier comments on updating gmock references in `LICENSE` and `entrypoint.sh`.
It's fixed now. Thanks for pointing me to `LICENSE`, `entrypoint.sh`, didn't think about them.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/#review175174
-----------------------------------------------------------
On May 17, 2017, noon, Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58349/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, noon)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7364
> https://issues.apache.org/jira/browse/MESOS-7364
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will fix various issues that occured with version 1.7.0.
> As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
> test cases have been updated accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
> 3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
> 3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
> 3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
> 3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
> 3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
> LICENSE 512b089c5dd2540f9f83afb559e5d0998d97ea22
> configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
> src/Makefile.am 1522c5b6fbd9cff4581f963716b131320e254373
> src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
> src/tests/containerizer/linux_capabilities_isolator_tests.cpp f9d2a532bb5bef4654474cb171911952218780fa
> src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
> src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
> src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
> support/mesos-style.py 53ffe3b080f50924acc8bffe66c47f15b4ea85af
> support/mesos-tidy/entrypoint.sh 5dbaa6086621934a7313dfa5c8008b6a6f5496f1
>
>
> Diff: https://reviews.apache.org/r/58349/diff/5/
>
>
> Testing
> -------
>
> Tested in https://reviews.apache.org/r/58351/
>
> Don't commit without 58350 and 58351.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/#review175174
-----------------------------------------------------------
Ship it!
There are more `tr1` references in `sorter_tests.cpp` -- can you fix these?
See also earlier comments on updating gmock references in `LICENSE` and `entrypoint.sh`.
- Neil Conway
On May 15, 2017, 12:05 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58349/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 12:05 p.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7364
> https://issues.apache.org/jira/browse/MESOS-7364
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will fix various issues that occured with version 1.7.0.
> As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
> test cases have been updated accordingly.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
> 3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
> 3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
> 3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
> 3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
> 3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
> configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
> src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
> src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
> src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
> src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
> src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
>
>
> Diff: https://reviews.apache.org/r/58349/diff/4/
>
>
> Testing
> -------
>
> Tested in https://reviews.apache.org/r/58351/
>
> Don't commit without 58350 and 58351.
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
-----------------------------------------------------------
(Updated May 15, 2017, 2:05 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Fixed CMake.
Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364
Repository: mesos
Description
-------
This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.
Diffs (updated)
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
Diff: https://reviews.apache.org/r/58349/diff/4/
Changes: https://reviews.apache.org/r/58349/diff/3-4/
Testing
-------
Tested in https://reviews.apache.org/r/58351/
Don't commit without 58350 and 58351.
Thanks,
Jan Schlicht
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/
-----------------------------------------------------------
(Updated May 15, 2017, 12:28 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Bugs: MESOS-7364
https://issues.apache.org/jira/browse/MESOS-7364
Repository: mesos
Description
-------
This will fix various issues that occured with version 1.7.0.
As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
test cases have been updated accordingly.
Diffs
-----
3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483
3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e
3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e
3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d
3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION
3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd
configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b
src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11
Diff: https://reviews.apache.org/r/58349/diff/3/
Testing (updated)
-------
Tested in https://reviews.apache.org/r/58351/
Don't commit without 58350 and 58351.
Thanks,
Jan Schlicht