You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 12:23:31 UTC
[GitHub] [superset] mayank-pant opened a new issue, #19690: SIP80 - curb the automatic query generation from superset for clickhouse
mayank-pant opened a new issue, #19690:
URL: https://github.com/apache/superset/issues/19690
### Motivation
Different databases have different ways to optimize query. There are some changes which are forced from superset side which inhibits the query performance at the back end. One such optimization for clickhouse i have identified.
### Proposed Change
Currently in bar-chart even when you have not selected LIMIT. LIMIT 50000<max value> still appears in the final query. If a table being queried uses a projection then clickhouse query optimizer gives inconsistent/wrong result for the query using both LIMIT and ORDER BY.
I propose that if we do not select limit from the GUI, then it should not appear automatically in the final query.
### New or Changed Public Interfaces
Dont have much idea about internals of superset but i have described my problem above.
### New dependencies
n.a
### Migration Plan and Compatibility
n.a
### Rejected Alternatives
n.a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayank-pant commented on issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by GitBox <gi...@apache.org>.
mayank-pant commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1100650952
I dont have idea if this is bug or a feature, author of projection was not clear on this part. But i am saying generally if we do not select any value in limit drop down, superset should not add limit to the query automatically. Pls ignore closed comment above, hastily clicked on the button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayank-pant commented on issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by GitBox <gi...@apache.org>.
mayank-pant commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1100650659
I dont have idea if this is bug or a feature, author of projection was not clear on this part. But i am saying generally if we do not select any value in limit drop down, superset should not add limit to the query automatically. Sorry for the late reply !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by GitBox <gi...@apache.org>.
srinify commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1098574392
This is great Mayank, thanks for opening this! I removed the "SIP" pre-fix, because that's reserved for big system level changes to Superset that needs lots of discussion and buy-in. This feels more like a database specific optimization & polish, which is awesome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1562014090
I don't think this is being worked on... but maybe someone (@villebro?) can validate that this is still an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayank-pant commented on issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by GitBox <gi...@apache.org>.
mayank-pant commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1102348942
Pls let me know if anyone will be working on this issue and any timeline will be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1099101642
@mayank-pant thanks for raising this issue. Did I understand correctly that this is something that's being worked on, i.e. might get fixed at some point? Or is this "a feature, not a bug"? There's a few solutions that we can consider, but I'd like to understand more about the underlying issue before going ahead with a fix..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayank-pant closed issue #19690: Curb the automatic query generation from superset for clickhouse
Posted by GitBox <gi...@apache.org>.
mayank-pant closed issue #19690: Curb the automatic query generation from superset for clickhouse
URL: https://github.com/apache/superset/issues/19690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Curb the automatic query generation from superset for clickhouse [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #19690:
URL: https://github.com/apache/superset/issues/19690#issuecomment-1975651893
Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Curb the automatic query generation from superset for clickhouse [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #19690: Curb the automatic query generation from superset for clickhouse
URL: https://github.com/apache/superset/issues/19690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org