You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/04/03 22:10:22 UTC
Review Request 66412: Fixed flaky agent test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
In test `KillTaskGroupBetweenRunTaskParts`, added extra
synchronization to ensure `unmocked__run` finishes before
the test tear down.
Also updated all dispatch calls to capture by value to avoid
potential races where the arguments might be destroyed
while the dispatch call is still running.
Diffs
-----
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66412/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200433
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66322', '66144', '66346', '66145', '66178', '66323', '66347', '66412']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1061 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (827 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (854 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (815 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (841 ms total)
[----------] Global test environment tear-down
[==========] 954 tests from 94 test cases ran. (459725 ms total)
[ PASSED ] 953 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stderr.log):
```
I0404 06:37:25.513232 7920 executor.cpp:176] Received SUBSCRIBED event
I0404 06:37:25.518230 7920 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 06:37:25.518230 7920 executor.cpp:176] Received LAUNCH event
I0404 06:37:25.525236 7920 executor.cpp:648] Starting task c635a982-3e44-4a4d-a39a-2beec177dbcf
I0404 06:37:25.629267 7920 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0404 06:37:25.659279 7920 executor.cpp:661] Forked command at 12556
I0404 06:37:25.692279 1244 exec.cpp:445] Executor asked to shutdown
I0404 06:37:25.693250 13560 executor.cpp:176] Received SHUTDOWN event
I0404 06:37:25.693250 13560 executor.cpp:758] Shutting down
I0404 06:37:25.693250 13560 executor.cpp:868] Sending SIGTERM to process tree at pid 8:52290
I0404 06:37:25.690253 11088 hierarchical.cpp:405] Deactivated framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000
I0404 06:37:25.690253 11500 slave.cpp:3973] Shutting down framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000
I0404 06:37:25.690253 1004 master.cpp:10449] Updating the state of task c635a982-3e44-4a4d-a39a-2beec177dbcf of framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0404 06:37:25.690253 11500 slave.cpp:6670] Shutting down executor 'c635a982-3e44-4a4d-a39a-2beec177dbcf' of framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000 at executor(1)@10.3.1.8:52311
I0404 06:37:25.691277 1460 slave.cpp:923] Agent terminating
W0404 06:37:25.691277 1460 slave.cpp:3969] Ignoring shutdown framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000 because it is terminating
I0404 06:37:25.693250 1004 master.cpp:10548] Removing task c635a982-3e44-4a4d-a39a-2beec177dbcf with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000 on agent f10602b3-e1d2-44d0-9787-5b47a0d956a7-S0 at slave(423)@10.3.1.8:52290 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 06:37:25.696254 11088 containerizer.cpp:2338] Destroying container a60ddab2-037a-4ee1-8ec7-5c26d708fb90 in RUNNING state
I0404 06:37:25.696254 11088 containerizer.cpp:2952] Transitioning the state of container a60ddab2-037a-4ee1-8ec7-5c26d708fb90 from RUNNING to DESTROYING
I0404 06:37:25.697278 11088 launcher.cpp:156] Asked to destroy container a60ddab2-037a-4ee1-8ec7-5c26d708fb90
I0404 06:37:25.697278 1004 master.cpp:1295] Agent f10602b3-e1d2-44d0-9787-5b47a0d956a7-S0 at slave(423)@10.3.1.8:52290 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 06:37:25.697278 1004 master.cpp:3286] Disconnecting agent f10602b3-e1d2-44d0-9787-5b47a0d956a7-S0 at slave(423)@10.3.1.8:52290 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 06:37:25.697278 5640 hierarchical.cpp:344] Removed framework f10602b3-e1d2-44d0-9787-5b47a0d956a7-0000
I0404 06:37:25.698249 1004 master.cpp:3305] Deactivating agent f10602b3-e1d2-44d0-9787-5b47a0d956a7-S0 at slave(423)@10.3.1.8:52290 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 06:37:25.698249 11768 hierarchical.cpp:766] Agent f10602b3-e1d2-44d0-9787-5b47a0d956a7-S0 deactivated
I0404 06:37:25.723171 12868 containerizer.cpp:2791] Container a60ddab2-037a-4ee1-8ec7-5c26d708fb90 has exited
I0404 06:37:25.755157 1460 master.cpp:1137] Master terminating
I0404 06:37:25.757163 13376 hierarchical.cpp:609] Removed agent f10602b3-e1d2-44d0-9787-5b47a0d956a7-S0
I0404 06:37:26.210929 10220 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 3, 2018, 3:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 3:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200443
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 66346, 66145, 66178, 66323, 66347, 66412]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 3, 2018, 10:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 10:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200477
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66126.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66126`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412
Relevant logs:
- [apply-review-66126-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/apply-review-66126-stdout.log):
```
error: patch failed: src/tests/slave_tests.cpp:4181
error: src/tests/slave_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On April 4, 2018, 7:23 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 7:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down. Added `AWAIT` calls in other
> tests that use dispatch calls to guard against potential
> similar issues.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200501
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66322', '66144', '66346', '66145', '66178', '66323', '66347', '66412']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (114 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1064 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (75 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (828 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (855 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (835 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (863 ms total)
[----------] Global test environment tear-down
[==========] 954 tests from 94 test cases ran. (460261 ms total)
[ PASSED ] 953 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stderr.log):
```
I0404 21:45:02.832861 3888 slave.cpp:3973] Shutting down framework 99588c03-1f27-4200-bd45-625c406a3e02-0000
I0404 21:45:02.831858 14660 master.cpp:10449] Updating the sI0404 21:45:02.638871 6128 exec.cpp:162] Version: 1.6.0
I0404 21:45:02.667873 4216 exec.cpp:236] Executor registered on agent 99588c03-1f27-4200-bd45-625c406a3e02-S0
I0404 21:45:02.671876 8072 executor.cpp:176] Received SUBSCRIBED event
I0404 21:45:02.676874 8072 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 21:45:02.677875 8072 executor.cpp:176] Received LAUNCH event
I0404 21:45:02.682873 8072 executor.cpp:648] Starting task a295962d-4f4e-4599-bd8a-33f77efa1514
I0404 21:45:02.774873 8072 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0404 21:45:02.804880 8072 executor.cpp:661] Forked command at 7240
I0404 21:45:02.834880 5960 exec.cpp:445] Executor asked to shutdown
I0404 21:45:02.834880 11880 executor.cpp:176] Received SHUTDOWN event
I0404 21:45:02.834880 11880 executor.cpp:758] Shutting down
I0404 21:45:02.834880 11880 executor.cpp:868] Sending SIGTERM to process tree at pid 7tate of task a295962d-4f4e-4599-bd8a-33f77efa1514 of framework 99588c03-1f27-4200-bd45-625c406a3e02-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0404 21:45:02.832861 3888 slave.cpp:6670] Shutting down executor 'a295962d-4f4e-4599-bd8a-33f77efa1514' of framework 99588c03-1f27-4200-bd45-625c406a3e02-0000 at executor(1)@10.3.1.8:55204
I0404 21:45:02.833878 3888 slave.cpp:923] Agent terminating
W0404 21:45:02.833878 3888 slave.cpp:3969] Ignoring shutdown framework 99588c03-1f27-4200-bd45-625c406a3e02-0000 because it is terminating
I0404 21:45:02.835871 14660 master.cpp:10548] Removing task a295962d-4f4e-4599-bd8a-33f77efa1514 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 99588c03-1f27-4200-bd45-625c406a3e02-0000 on agent 99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 21:45:02.837882 6484 containerizer.cpp:2338] Destroying container 52fc0a76-d8b3-4846-9ee9-8c22958172b6 in RUNNING state
I0404 21:45:02.837882 14660 master.cpp:1295] Agent 99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 21:45:02.837882 14660 master.cpp:3286] Disconnecting agent 99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 21:45:02.838881 6484 containerizer.cpp:2952] Transitioning the state of container 52fc0a76-d8b3-4846-9ee9-8c22958172b6 from RUNNING to DESTROYING
I0404 21:45:02.838881 14660 master.cpp:3305] Deactivating agent 99588c03-1f27-4200-bd45-625c406a3e02-S0 at slave(423)@10.3.1.8:55183 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 21:45:02.838881 12644 hierarchical.cpp:344] Removed framework 99588c03-1f27-4200-bd45-625c406a3e02-0000
I0404 21:45:02.839882 6484 launcher.cpp:156] Asked to destroy container 52fc0a76-d8b3-4846-9ee9-8c22958172b6
I0404 21:45:02.839882 12644 hierarchical.cpp:766] Agent 99588c03-1f27-4200-bd45-625c406a3e02-S0 deactivated
I0404 21:45:02.928000 2128 containerizer.cpp:2791] Container 52fc0a76-d8b3-4846-9ee9-8c22958172b6 has exited
I0404 21:45:02.963997 10728 master.cpp:1137] Master terminating
I0404 21:45:02.967000 4140 hierarchical.cpp:609] Removed agent 99588c03-1f27-4200-bd45-625c406a3e02-S0
I0404 21:45:03.411011 10288 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 4, 2018, 7:23 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 7:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down. Added `AWAIT` calls in other
> tests that use dispatch calls to guard against potential
> similar issues.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200529
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 66346, 66145, 66178, 66323, 66347, 66412]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 4, 2018, 12:23 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 12:23 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down. Added `AWAIT` calls in other
> tests that use dispatch calls to guard against potential
> similar issues.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/
-----------------------------------------------------------
(Updated April 4, 2018, 12:23 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Added extra synchronouzation to guard against potential race conditions.
Repository: mesos
Description (updated)
-------
In test `KillTaskGroupBetweenRunTaskParts`, added extra
synchronization to ensure `unmocked__run` finishes before
the test tear down. Added `AWAIT` calls in other
tests that use dispatch calls to guard against potential
similar issues.
Also updated all dispatch calls to capture by value to avoid
potential races where the arguments might be destroyed
while the dispatch call is still running.
Diffs (updated)
-----
src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
Diff: https://reviews.apache.org/r/66412/diff/3/
Changes: https://reviews.apache.org/r/66412/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200402
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66118', '66119', '66120', '65679', '66126', '66143', '66322', '66144', '66145', '66178', '66323', '66346', '66347', '66412']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1069 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (835 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (860 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (834 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (860 ms total)
[----------] Global test environment tear-down
[==========] 954 tests from 94 test cases ran. (469753 ms total)
[ PASSED ] 953 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/mesos-tests-stderr.log):
```
I0403 23:04:33.120618 6728 master.cpp:10449] Updating the state of task 8383afcf-80b8-4b1d-8f92-357dd43a05e5 of framework 20e0e59c-20f3-4d45-8f75-d85e140a7e00-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0403 23:04:33.120618 5904 slave.cpp:3973] Shutting down framework 20e0e59c-20f3-4d45-8f75-d85e140a7e00-0000
I0403 23:04:33.120618 5904 slave.cpp:6670] Shutting down executor '8383afcf-80b8-4b1d-8f92-357dd43a05e5' of framework 20e0e59c-20f3-4d45-8f75-d85e140a7e00-0000 at executor(1)@10.3.1.8:61262
I0403 23:04:33.121605 5700 slave.cI0403 23:04:32.941620 9416 exec.cpp:162] Version: 1.6.0
I0403 23:04:32.970605 9808 exec.cpp:236] Executor registered on agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0
I0403 23:04:32.974613 7368 executor.cpp:176] Received SUBSCRIBED event
I0403 23:04:32.978612 7368 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0403 23:04:32.978612 7368 executor.cpp:176] Received LAUNCH event
I0403 23:04:32.983613 7368 executor.cpp:648] Starting task 8383afcf-80b8-4b1d-8f92-357dd43a05e5
I0403 23:04:33.061606 7368 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0403 23:04:33.087615 7368 executor.cpp:661] Forked command at 10384
I0403 23:04:33.122601 6160 exec.cpp:445] Executor asked to shutdown
I0403 23:04:33.122601 7020 executor.cpp:176] Received SHUTDOWN event
I0403 23:04:33.122601 7020 executor.cpp:758] Shutting down
I0403 23:04:33.122601 7020 executor.cpp:868] Sending SIGTERM to process tree at pid pp:923] Agent terminating
W0403 23:04:33.122601 5700 slave.cpp:3969] Ignoring shutdown framework 20e0e59c-20f3-4d45-8f75-d85e140a7e00-0000 because it is terminating
I0403 23:04:33.122601 6728 master.cpp:10548] Removing task 8383afcf-80b8-4b1d-8f92-357dd43a05e5 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 20e0e59c-20f3-4d45-8f75-d85e140a7e00-0000 on agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0 at slave(423)@10.3.1.8:61241 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0403 23:04:33.125607 6728 master.cpp:1295] Agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0 at slave(423)@10.3.1.8:61241 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0403 23:04:33.125607 6728 master.cpp:3286] Disconnecting agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0 at slave(423)@10.3.1.8:61241 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0403 23:04:33.125607 6728 master.cpp:3305] Deactivating agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0 at slave(423)@10.3.1.8:61241 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0403 23:04:33.126626 3512 hierarchical.cpp:344] Removed framework 20e0e59c-20f3-4d45-8f75-d85e140a7e00-0000
I0403 23:04:33.126626 13140 containerizer.cpp:2338] Destroying container 91ecf3c9-ee61-432c-b06a-220a94a82059 in RUNNING state
I0403 23:04:33.126626 13140 containerizer.cpp:2952] Transitioning the state of container 91ecf3c9-ee61-432c-b06a-220a94a82059 from RUNNING to DESTROYING
I0403 23:04:33.126626 3512 hierarchical.cpp:766] Agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0 deactivated
I0403 23:04:33.127617 13140 launcher.cpp:156] Asked to destroy container 91ecf3c9-ee61-432c-b06a-220a94a82059
I0403 23:04:33.238870 12256 containerizer.cpp:2791] Container 91ecf3c9-ee61-432c-b06a-220a94a82059 has exited
I0403 23:04:33.271828 13200 master.cpp:1137] Master terminating
I0403 23:04:33.273828 3512 hierarchical.cpp:609] Removed agent 20e0e59c-20f3-4d45-8f75-d85e140a7e00-S0
I0403 23:04:33.683845 11248 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 3, 2018, 3:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 3:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On April 3, 2018, 5:59 p.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 9093-9094 (patched)
> > <https://reviews.apache.org/r/66412/diff/1/?file=1991918#file1991918line9093>
> >
> > Why this change?
Removed. And changed await_ready to await.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200407
-----------------------------------------------------------
On April 3, 2018, 3:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 3:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200407
-----------------------------------------------------------
src/tests/slave_tests.cpp
Lines 9093-9094 (patched)
<https://reviews.apache.org/r/66412/#comment281176>
Why this change?
- Greg Mann
On April 3, 2018, 10:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 10:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66412: Fixed flaky agent test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66412/#review200410
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 66145, 66178, 66323, 66346, 66347, 66412]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 3, 2018, 10:10 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66412/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 10:10 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In test `KillTaskGroupBetweenRunTaskParts`, added extra
> synchronization to ensure `unmocked__run` finishes before
> the test tear down.
>
> Also updated all dispatch calls to capture by value to avoid
> potential races where the arguments might be destroyed
> while the dispatch call is still running.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353
>
>
> Diff: https://reviews.apache.org/r/66412/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>