[GitHub] [spark] zhengruifeng commented on a diff in pull request #40228: [SPARK-41874][CONNECT][PYTHON] Support SameSemantics in Spark Connect

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #40228:
URL: https://github.com/apache/spark/pull/40228#discussion_r1121038700


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2724,7 +2724,7 @@ class Dataset[T] private[sql] (
   }
 
   def sameSemantics(other: Dataset[T]): Boolean = {

Review Comment:
   
   It seems @hvanhovell and  @cloud-fan  had some concerns in `sameSemantics` and `semanticHash`
   
   https://github.com/apache/spark/pull/38742#discussion_r1029446204
   
   https://github.com/apache/spark/pull/38742#discussion_r1031014545



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org