You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Aakash Nand <aa...@gmail.com> on 2022/08/04 05:29:52 UTC

Review Request 74082: RANGER-3850 Upgrade trino plugin to JDK17

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74082/
-----------------------------------------------------------

Review request for ranger and Ramesh Mani.


Bugs: RANGER-3850
    https://issues.apache.org/jira/browse/RANGER-3850


Repository: ranger


Description
-------

From version 390 onwards, trino have started using JDK17 and from trino version 393 onwards the language level will also be updated to JDK17. Therefore trino plugin needs to be updated


Diffs
-----

  distro/src/main/assembly/plugin-trino.xml 60b083ed6 
  plugin-trino/pom.xml e7c82edfa 
  plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java cc06187f4 
  pom.xml 0945f4b1d 
  ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java c6b234dc2 


Diff: https://reviews.apache.org/r/74082/diff/1/


Testing
-------

Tested and deployed locally with trino version 391


Thanks,

Aakash Nand

Re: Review Request 74082: RANGER-3850 Upgrade trino plugin to JDK17

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74082/#review225075
-----------------------------------------------------------




pom.xml
Line 72 (original), 72 (patched)
<https://reviews.apache.org/r/74082/#comment313876>

    We don't want to change the java version here as this needs the whole ranger and plugins verification. Since Trino has a sepecific profile to build against the different version of java, only the profile ranger-jdk11 needs change. Please verify


- Ramesh Mani


On Aug. 4, 2022, 5:29 a.m., Aakash Nand wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74082/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2022, 5:29 a.m.)
> 
> 
> Review request for ranger and Ramesh Mani.
> 
> 
> Bugs: RANGER-3850
>     https://issues.apache.org/jira/browse/RANGER-3850
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> From version 390 onwards, trino have started using JDK17 and from trino version 393 onwards the language level will also be updated to JDK17. Therefore trino plugin needs to be updated
> 
> 
> Diffs
> -----
> 
>   distro/src/main/assembly/plugin-trino.xml 60b083ed6 
>   plugin-trino/pom.xml e7c82edfa 
>   plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java cc06187f4 
>   pom.xml 0945f4b1d 
>   ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java c6b234dc2 
> 
> 
> Diff: https://reviews.apache.org/r/74082/diff/1/
> 
> 
> Testing
> -------
> 
> Tested and deployed locally with trino version 391
> 
> 
> Thanks,
> 
> Aakash Nand
> 
>