You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Everett Toews <no...@github.com> on 2014/04/09 17:54:46 UTC
[jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes() (#342)
Also alphabetized the Server.Status in toPortableNodeStatus to make it easier to see if any statuses are missed.
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds fix-npe
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/342
-- Commit Summary --
* JCLOUDS-317: Fix NPE when ComputeService.listNodes()
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/config/NovaComputeServiceContextModule.java (39)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/ServerInZoneToNodeMetadataTest.java (9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/342.patch
https://github.com/jclouds/jclouds/pull/342.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1009](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1009/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-39987603
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by Andrew Phillips <no...@github.com>.
Closed #342.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=84e0b91179be6921ef0ce7be63934fe4c374f690) and [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=5b9f6b76465249d6b51a5820130258cfd0a52256)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-39999657
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1213](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1213/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-39987994
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by Everett Toews <no...@github.com>.
Thanks @demobox!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-40017919
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by Everett Toews <no...@github.com>.
Looks like an IO problem with CloudBees/Jenkins
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-39981689
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by Andrew Phillips <no...@github.com>.
> @@ -196,7 +196,14 @@ public void testAlternateAccessIPs() {
> assertEquals(convertedNodeMetadata.getPublicAddresses(), ImmutableSet.of("67.23.10.132", "67.23.10.131", "76.32.1.231"));
> }
>
> - // TODO: clean up this syntax
> + @Test
> + public void testPortableNodeStatusNotNull() {
> + for (Server.Status serverStatus: Server.Status.values()) {
> + assertNotNull(NovaComputeServiceContextModule.toPortableNodeStatus.get(serverStatus));
I'm assuming this test does indeed fail on the current code..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342/files#r11443519
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #743](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/743/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-39981463
Re: [jclouds] JCLOUDS-317: Fix NPE when ComputeService.listNodes()
(#342)
Posted by Andrew Phillips <no...@github.com>.
Let's see what BuildHive says. This looks good to me. Also needs to be backported to 1.7.x, I guess.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/342#issuecomment-39982885