You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/09/21 17:29:33 UTC
[GitHub] [cordova-cli] dependabot[bot] opened a new pull request, #627: chore(deps): bump systeminformation from 5.17.12 to 5.21.7
dependabot[bot] opened a new pull request, #627:
URL: https://github.com/apache/cordova-cli/pull/627
Bumps [systeminformation](https://github.com/sebhildebrandt/systeminformation) from 5.17.12 to 5.21.7.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/sebhildebrandt/systeminformation/blob/master/CHANGELOG.md">systeminformation's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>Major Changes - Version 5</h2>
<h4>New Functions</h4>
<ul>
<li><code>audio()</code> detailed audio information</li>
<li><code>bluetoothDevices()</code> detailed information detected bluetooth devices</li>
<li><code>dockerImages()</code> detailed information docker images</li>
<li><code>dockerVolumes()</code> detailed information docker volumes</li>
<li><code>printers()</code> detailed printer information</li>
<li><code>usb()</code> detailed USB information</li>
<li><code>wifiInterfaces()</code> detected Wi-Fi interfaces</li>
<li><code>wifiConnections()</code> active Wi-Fi connections</li>
</ul>
<h4>Breaking Changes</h4>
<p><strong>Be aware</strong>, that the new version 5.x <strong>is NOT fully backward compatible</strong> to version 4.x ...</p>
<p>We had to make <strong>several interface changes</strong> to keep systeminformation as consistent as possible. We highly <a href="https://systeminformation.io/changes.html">recommend to go through the complete list</a> and adapt your own code to be again compatible to the new version 5.</p>
<table>
<thead>
<tr>
<th>Function</th>
<th>Old</th>
<th>New (V5)</th>
<th>Comments</th>
</tr>
</thead>
<tbody>
<tr>
<td>unsupported values</td>
<td>-1</td>
<td>null</td>
<td>values which are unknown or<!-- raw HTML omitted -->unsupported on platform</td>
</tr>
<tr>
<td><code>battery()</code></td>
<td>hasbattery<!-- raw HTML omitted -->cyclecount<!-- raw HTML omitted -->ischarging<!-- raw HTML omitted -->designedcapacity<!-- raw HTML omitted -->maxcapacity<!-- raw HTML omitted -->acconnected<!-- raw HTML omitted -->timeremaining</td>
<td>hasBattery<!-- raw HTML omitted -->cycleCount<!-- raw HTML omitted -->isCharging<!-- raw HTML omitted -->designedCapacity<!-- raw HTML omitted -->maxCapacity<!-- raw HTML omitted -->acConnected<!-- raw HTML omitted -->timeRemaining</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>blockDevices()</code></td>
<td>fstype</td>
<td>fsType</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>cpu()</code></td>
<td>speedmin<!-- raw HTML omitted -->speedmax</td>
<td>speedMin<!-- raw HTML omitted -->speedMax</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>cpu().speed</code><!-- raw HTML omitted --><code>cpu().speedMin</code><!-- raw HTML omitted --><code>cpu().speedMax</code></td>
<td>string values</td>
<td>now returning<!-- raw HTML omitted -->numerical values</td>
<td>better value handling</td>
</tr>
<tr>
<td><code>cpuCurrentspeed()</code></td>
<td></td>
<td>cpuCurrentSpeed()</td>
<td>function name changed<!-- raw HTML omitted -->pascalCase conformity</td>
</tr>
<tr>
<td><code>currentLoad()</code></td>
<td>avgload<!-- raw HTML omitted -->currentload<!-- raw HTML omitted -->currentload_user<!-- raw HTML omitted -->currentload_system<!-- raw HTML omitted -->currentload_nice<!-- raw HTML omitted -->currentload_idle<!-- raw HTML omitted -->currentload_irq<!-- raw HTML omitted -->raw_currentload</td>
<td>avgLoad<!-- raw HTML omitted -->currentLoad<!-- raw HTML omitted -->currentLoadUser<!-- raw HTML omitted -->currentLoadSystem<!-- raw HTML omitted -->currentLoadNice<!-- raw HTML omitted -->currentLoadIdle<!-- raw HTML omitted -->currentLoadIrq<!-- raw HTML omitted -->rawCurrentLoad</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>dockerContainerStats()</code></td>
<td>mem_usage<!-- raw HTML omitted -->mem_limit<!-- raw HTML omitted -->mem_percent<!-- raw HTML omitted -->cpu_percent<!-- raw HTML omitted -->cpu_stats<!-- raw HTML omitted -->precpu_stats<!-- raw HTML omitted -->memory_stats</td>
<td>memUsage<!-- raw HTML omitted -->memLimit<!-- raw HTML omitted -->memPercent<!-- raw HTML omitted -->cpuPercent<!-- raw HTML omitted -->cpuStats<!-- raw HTML omitted -->precpuStats<!-- raw HTML omitted -->memoryStats</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>dockerContainerProcesses()</code></td>
<td>pid_host</td>
<td>pidHost</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>graphics().display</code></td>
<td>pixeldepth<!-- raw HTML omitted -->resolutionx<!-- raw HTML omitted -->resolutiony<!-- raw HTML omitted -->sizex<!-- raw HTML omitted -->sizey</td>
<td>pixelDepth<!-- raw HTML omitted -->resolutionX<!-- raw HTML omitted -->resolutionY<!-- raw HTML omitted -->sizeX<!-- raw HTML omitted -->sizeY</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>networkConnections()</code></td>
<td>localaddress<!-- raw HTML omitted -->localport<!-- raw HTML omitted -->peeraddress<!-- raw HTML omitted -->peerport</td>
<td>localAddress<!-- raw HTML omitted -->localPort<!-- raw HTML omitted -->peerAddress<!-- raw HTML omitted -->peerPort</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>networkInterfaces()</code></td>
<td>carrier_changes</td>
<td>carrierChanges</td>
<td>pascalCase conformity</td>
</tr>
<tr>
<td><code>processes()</code></td>
<td>mem_vsz<!-- raw HTML omitted -->mem_rss<!-- raw HTML omitted -->pcpu<!-- raw HTML omitted -->pcpuu<!-- raw HTML omitted -->pcpus<!-- raw HTML omitted -->pmem</td>
<td>memVsz<!-- raw HTML omitted -->memRss<!-- raw HTML omitted -->cpu<!-- raw HTML omitted -->cpuu<!-- raw HTML omitted -->cpus<!-- raw HTML omitted -->mem</td>
<td>pascalCase conformity<!-- raw HTML omitted -->renamed attributes</td>
</tr>
<tr>
<td><code>processLoad()</code></td>
<td>result as object</td>
<td>result as array of objects</td>
<td>function now allows to provide more than<!-- raw HTML omitted -->one process (as a comma separated list)</td>
</tr>
<tr>
<td><code>services()</code></td>
<td>pcpu<!-- raw HTML omitted -->pmem</td>
<td>cpu<!-- raw HTML omitted -->mem</td>
<td>renamed attributes</td>
</tr>
<tr>
<td><code>vbox()</code></td>
<td>HPET<!-- raw HTML omitted -->PAE<!-- raw HTML omitted -->APIC<!-- raw HTML omitted -->X2APIC<!-- raw HTML omitted -->ACPI<!-- raw HTML omitted -->IOAPIC<!-- raw HTML omitted -->biosAPICmode<!-- raw HTML omitted -->TRC</td>
<td>hpet<!-- raw HTML omitted -->pae<!-- raw HTML omitted -->apic<!-- raw HTML omitted -->x2Apic<!-- raw HTML omitted -->acpi<!-- raw HTML omitted -->ioApic<!-- raw HTML omitted -->biosApicMode<!-- raw HTML omitted -->rtc</td>
<td>pascalCase conformity</td>
</tr>
</tbody>
</table>
<h4>Other Improvements and Changes</h4>
<ul>
<li><code>baseboard()</code>: added memMax, memSlots</li>
<li><code>bios()</code>: added language and features (linux)</li>
<li><code>blockDevices()</code> added raid group member (linux)</li>
<li><code>cpu()</code>: extended AMD processor list</li>
<li><code>cpu()</code>: extended socket list (win)</li>
<li><code>cpu()</code>: added virtualization if cpu supports virtualization</li>
<li><code>cpu()</code>: now flags are part of this function</li>
<li><code>cpuTemperature()</code> added socket and chipset temp (linux)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/f6a0bd3fb2127bcafe27703ee7d853276c072799"><code>f6a0bd3</code></a> 5.21.7</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/cdfcbde1aa02f64b142c9e6e76289a3a6c8e3e94"><code>cdfcbde</code></a> updated docs</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/7972565812ccb2a610a22911c54c3446f4171392"><code>7972565</code></a> wifi sanitizing ssid names</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/d93a0ce510b861b4f65f888a81b12108ddc82db3"><code>d93a0ce</code></a> wifi sanitizing iface names</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/3c11b2200d234e5750475ce548db1e48bba0956e"><code>3c11b22</code></a> wifi sanitizing iface names</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/c184c79f8422ae17c442807dbdcd31e819c61c5a"><code>c184c79</code></a> 5.21.6</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/1b62892f863aac25245fcbb6d0e5b2967c309312"><code>1b62892</code></a> baseboard() improved parsing (windows)</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/734b52e28b7f3af9f0dbfd06c5ffb63a00d178ec"><code>734b52e</code></a> 5.21.5</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/369532fd17160fd4f4c6b5b3f39f1dfa232d3d9b"><code>369532f</code></a> chassis(), baseboard() improved parsing (windows)</li>
<li><a href="https://github.com/sebhildebrandt/systeminformation/commit/26f2b140ff456384d563ad5c6cad9b4b33ce0cc8"><code>26f2b14</code></a> chassis(), baseboard() parsing improvements (windows)</li>
<li>Additional commits viewable in <a href="https://github.com/sebhildebrandt/systeminformation/compare/v5.17.12...v5.21.7">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/cordova-cli/network/alerts).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1854564318
> Hi @erisu, could you merge this PR ? It fixes a critical vulnerability
>
> `npm audit` output on an app running `cordova@12.0.0`:
>
> ```
> systeminformation 5.0.0 - 5.21.6
> Severity: critical
> systeminformation SSID Command Injection Vulnerability - https://github.com/advisories/GHSA-gx6r-qc2v-3p3v
> fix available via `npm audit fix`
> node_modules/systeminformation
> ```
This PR won't correct end-user apps, it will just correct local development environments when developing the CLI.
Apps/libraries consuming cordova needs to update their own package-lock.json files.
If you have cordova globally installed, then `npm install -g cordova@12.0.1` should automatically do this.
If you have cordova locally installed, then you'll need to issue `npm upgrade` which will upgrade your entire dependency tree to the latest satisfactory packages possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "shajz (via GitHub)" <gi...@apache.org>.
shajz commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1856085800
Woops, well spotted @breautek, I assumed too that it also bumped this repo's `package.json` (and the published one). Maybe we could amend this PR to reflect these changes in the `package.json` file to make them available to everyone in a future version ?
> If you have cordova globally installed, then npm install -g cordova@12.0.1 should automatically do this.
I'm not seeing the 12.0.1 release you mention, neither here nor on npm 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1856098552
> I'm not seeing the 12.0.1 release you mention, neither here nor on npm
Oops, my bad, that's still in dev, the current latest is 12.0.0
> Woops, well spotted @breautek, I was quick to assume that this PR also bumped this repo's package.json (and the published one). Maybe we could amend this PR to reflect these changes in the package.json file to make them available to everyone in a future version ?
I made a [PR](https://github.com/apache/cordova-cli/pull/631) to address the package.json for this + several other NPM audits that is outstanding in the current package-lock.json state. There's still audit issues from the `insight` package that needs to be addressed and that's not as simple as a version bump. So that will remain currently. To re-iterate you don't need this or my PR to address the systeminformation concern, you just need to `npm upgrade` (if yo have cordova locally installed in your project) or `npm install -g cordova@latest` and NPM will reinstall cordova globally with the latest dependency tree information. This works because cordova has the version pin to allow for any version in 5.x range for systeminformation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] codecov-commenter commented on pull request #627: chore(deps): bump systeminformation from 5.17.12 to 5.21.7
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1730012715
## [Codecov](https://app.codecov.io/gh/apache/cordova-cli/pull/627?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#627](https://app.codecov.io/gh/apache/cordova-cli/pull/627?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9fd10ec) into [master](https://app.codecov.io/gh/apache/cordova-cli/commit/bff99d33e7d9fbe2f7821508d8674c7ac35af6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bff99d3) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 70.68% 70.68%
=======================================
Files 4 4
Lines 307 307
=======================================
Hits 217 217
Misses 90 90
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "shajz (via GitHub)" <gi...@apache.org>.
shajz commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1856104802
Yes I've just seen your PR, thanks for the effort! Much appreciated <3 It will actually fix this vulnerability without forcing users to meddle with their package-lock file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] closed pull request #627: chore(deps): bump systeminformation from 5.17.12 to 5.21.7
URL: https://github.com/apache/cordova-cli/pull/627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1857145720
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "shajz (via GitHub)" <gi...@apache.org>.
shajz commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1854545903
Hi @erisu, could you merge this PR ? It fixes a critical vulnerability
npm audit output on an running cordova@12.0.0:
```
systeminformation 5.0.0 - 5.21.6
Severity: critical
systeminformation SSID Command Injection Vulnerability - https://github.com/advisories/GHSA-gx6r-qc2v-3p3v
fix available via `npm audit fix`
node_modules/systeminformation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): bump systeminformation from 5.17.12 to 5.21.7 [cordova-cli]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #627:
URL: https://github.com/apache/cordova-cli/pull/627#issuecomment-1857145970
Looks like systeminformation is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org