You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2009/10/27 12:18:59 UTC
[jira] Created: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Remove deprecated Scorer.explain(int) method
--------------------------------------------
Key: LUCENE-2011
URL: https://issues.apache.org/jira/browse/LUCENE-2011
Project: Lucene - Java
Issue Type: Task
Components: Search
Reporter: Uwe Schindler
Fix For: 3.0
This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in score. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770533#action_12770533 ]
Uwe Schindler commented on LUCENE-2011:
---------------------------------------
...had the same idea - and problem.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-2011.
-----------------------------------
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [New])
Committed revision: 830377
Thanks Mark!
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011-bw.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Attachment: (was: LUCENE-2011.patch)
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Attachment: LUCENE-2011.patch
I reanimated the TestNearSpan test. TestTermScorer.testExplain cannot be reanimated, because it tests the lower level tfExplanation only and it is not easy to get from the Weight.
Contrib builds and tests without problems.
So only one failing test :-)
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770585#action_12770585 ]
Uwe Schindler commented on LUCENE-2011:
---------------------------------------
All tests pass, I think it is now ready to commit. Will commit in a day.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011-bw.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-2011:
--------------------------------
Attachment: LUCENE-2011.patch
*cough* hack *cough*.
If we went this way, we should prob also hack termweight#explain too so that i can still use the cache.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770525#action_12770525 ]
Mark Miller edited comment on LUCENE-2011 at 10/27/09 2:37 PM:
---------------------------------------------------------------
Its because of the loss of whats going on in PayloadTermQuery - we also lose some custom info from PayloadNearQuery - on first blush it seems best just to leave the exp in the scorer for Span queries - its still gone from Scorer so I don't see it as much of a problem myself - havn't thought on it much yet though.
I guess we could pull all that custom info up to the weight through the span/payload stuff - but then each has to duplicate a bunch of the info from the SpanWeight - it seems nicer just to leave things as they are, let the Scorer do it, and cast. What do you think?
was (Author: markrmiller@gmail.com):
Its because of the loss of whats going on in PayloadTermQuery - we also lose some custom info from PayloadNearQuery - on first blush it seems best just to leave the exp in the scorer for Span queries - its still gone from Scorer so I don't see it as much of a problem myself - havn't thought on it much yet though.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Attachment: LUCENE-2011-bw.patch
Attached the backwards branch patch.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011-bw.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770498#action_12770498 ]
Uwe Schindler commented on LUCENE-2011:
---------------------------------------
I have a patch here which moves the explain part from the scorer to the weight. Almost all test pass, only a few. I can post this here, and maybe you fix the rmaining issues.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770508#action_12770508 ]
Uwe Schindler commented on LUCENE-2011:
---------------------------------------
{quote}
*cough* hack *cough*.
If we went this way, we should prob also hack termweight#explain too so that i can still use the cache.
{quote}
The cache was of no use for TermWeight.explain, because the explain method created a new Scorer.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770532#action_12770532 ]
Mark Miller commented on LUCENE-2011:
-------------------------------------
Nice on protected - i wanted to package private it, but couldnt because of the payloads package - good call.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Attachment: LUCENE-2011.patch
Only TestPayloadTermQuery fails with wrong explanations.
This patch also adds lots of @Override, because only by this I can test that I do not override a no longer available method.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770509#action_12770509 ]
Uwe Schindler commented on LUCENE-2011:
---------------------------------------
bq. I'd say lets go with your patch and just fix that test.
Is the test wrong or my code?
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Description: This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight. (was: This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in score. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.)
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770505#action_12770505 ]
Mark Miller commented on LUCENE-2011:
-------------------------------------
Okay, nice - looks like we are pretty similar - you just pulled some more cruft that I didn't and pulled the phrasequery/spanquery stuff up a level it looks. My hack was to keep them were they are, make them package private, and just cast the scorer ;)
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-2011:
--------------------------------
Attachment: LUCENE-2011.patch
Its because of the loss of whats going on in PayloadTermQuery - we also lose some custom info from PayloadNearQuery - on first blush it seems best just to leave the exp in the scorer for Span queries - its still gone from Scorer so I don't see it as much of a problem myself - havn't thought on it much yet though.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reassigned LUCENE-2011:
-------------------------------------
Assignee: Uwe Schindler
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011-bw.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770492#action_12770492 ]
Mark Miller commented on LUCENE-2011:
-------------------------------------
I think I've everything but the PhraseQuery issue - thats a tough one though, and extends to MultiPhraseQuery and SpanQuery.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Attachment: LUCENE-2011.patch
An updated patch, I added the termDocs==null case in the TermQuery explanation (you did it correctly).
If you can somehow fix the PayloadTermQuery, I would be happy. By the way, I have to cast the scorers, too, to get the current freq value (I added a method to these scorers to get them).
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2011) Remove deprecated Scorer.explain(int)
method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2011:
----------------------------------
Attachment: LUCENE-2011.patch
Added the test to your patch.
I also made explain() in SpanScorer protected.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770526#action_12770526 ]
Uwe Schindler commented on LUCENE-2011:
---------------------------------------
Looks good. I also thought about it and I also think, whe should just leave an explain() in SpanScorer, maybe we should make it package-protected or protected, because it is no longer public.
In my last patch I only reanimated the TestNearSpan test.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770505#action_12770505 ]
Mark Miller edited comment on LUCENE-2011 at 10/27/09 1:42 PM:
---------------------------------------------------------------
Okay, nice - looks like we are pretty similar - you just pulled some more cruft that I didn't and pulled the phrasequery/spanquery stuff up a level it looks. My hack was to keep them were they are, make them package private, and just cast the scorer ;)
I'd say lets go with your patch and just fix that test.
was (Author: markrmiller@gmail.com):
Okay, nice - looks like we are pretty similar - you just pulled some more cruft that I didn't and pulled the phrasequery/spanquery stuff up a level it looks. My hack was to keep them were they are, make them package private, and just cast the scorer ;)
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2011) Remove deprecated
Scorer.explain(int) method
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770504#action_12770504 ]
Mark Miller commented on LUCENE-2011:
-------------------------------------
Okay, Uwe - perhaps we can merge and get something nice - I didn't do anything with contrib with my patch as well.
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
> Key: LUCENE-2011
> URL: https://issues.apache.org/jira/browse/LUCENE-2011
> Project: Lucene - Java
> Issue Type: Task
> Components: Search
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org