[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079500#comment-16079500 ] 

Deepak Dixit commented on OFBIZ-9403:
-------------------------------------

Hi Martin,

Why we are returning default mime type id in this methods?

I think it should not return default mime type, instead  it should return null so that at the calling end we can take decision accordingly  

> DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-9403
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9403
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Martin Becker
>            Assignee: Deepak Dixit
>            Priority: Trivial
>         Attachments: OFBIZ-9403_DataResourceWorker-getMimeType.patch
>
>
> The method DataResourceWorker.getMimeType(GenericValue) has been refactored into two separate methods. The new additional method getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the MimeType from the file extension and is invoked by getMimeType(GenericValue) if needed. getMimeType returns the type if possible via the data resource. This results in cleaner code with the responsibility of both methods clearly defined by the methods names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)