Re: [Apache Bloodhound] #220: Upgrade Bootstrap to 2.3

[Apache Bloodhound <bl...@incubator.apache.org>]

#220: Upgrade Bootstrap to 2.3
------------------------+-----------------------
  Reporter:  jdreimann  |      Owner:  nobody
      Type:  task       |     Status:  new
  Priority:  major      |  Milestone:  Release 5
 Component:  ui design  |    Version:
Resolution:             |   Keywords:
------------------------+-----------------------

Comment (by rjollos):

 The package available at includes on `bootstrap.js`.  However, we
 currently have:
 {{{
 user@debian-wheezy:~/Workspace/bh220$ ls
 bloodhound_dashboard/bhdashboard/htdocs/js/
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-affix.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-alert.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-button.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-carousel.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-collapse.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-dropdown.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-modal.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-popover.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-scrollspy.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-tab.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-tooltip.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-transition.js
 bloodhound_dashboard/bhdashboard/htdocs/js/bootstrap-typeahead.js
 }}}



 {{{
 user@debian-wheezy:~/Workspace/bh220$ grep -R --exclude-dir=.svn
 --exclude-dir=htdocs --exclude=*.pyc --exclude-dir=*.egg-info
 bootstrap-.*.js bloodhound_*
 bloodhound_dashboard/bhdashboard/layouts/bootstrap.py:
 add_script(req, 'dashboard/js/bootstrap-button.js')
 bloodhound_dashboard/bhdashboard/layouts/bootstrap.py:
 add_script(req, 'dashboard/js/bootstrap-tab.js')
 bloodhound_theme/bhtheme/theme.py:        add_script(req, 'dashboard/js
 /bootstrap-scrollspy.js')
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-transition.js')}"
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-alert.js')}"
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-dropdown.js')}"
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-tooltip.js')}"
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-popover.js')}"
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-affix.js')}"
 bloodhound_theme/bhtheme/templates/bloodhound_theme.html:    <script
 src="${href.chrome('dashboard/js/bootstrap-button.js')}"
 bloodhound_theme/bhtheme/templates/bh_admin_plugins.html:
 src="${href.chrome('dashboard/js/bootstrap-collapse.js')}"></script>
 }}}

 It looks like there would be a fairly limited number of changes to just
 include `bootstrap.js` rather than the `bootstrap-*.js` files.
 `bootstrap.js` is 61 kB and would be cached so I can't see the harm in
 this. Thoughts?

 Some updates in the `doc` dir would also be necessary:

 {{{
 user@debian-wheezy:~/Workspace/bh220$ grep -R --exclude-dir=.svn
 --exclude-dir=htdocs --exclude=*.pyc --exclude-dir=*.egg-info
 bootstrap-.*.js doc
 doc/html-templates/search.html:    <script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/search.html:    <script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/source.html:<script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/source.html:<script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/wiki.html:<script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/wiki.html:<script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/milestone.html:    <script type="text/javascript"
 src="js/bootstrap-dropdown.js"></script>
 doc/html-templates/milestone.html:    <script type="text/javascript"
 src="js/bootstrap-button.js"></script>
 doc/html-templates/js/bootstrap-modal.js: * bootstrap-modal.js v2.0.2
 doc/html-templates/js/bootstrap-button.js: * bootstrap-button.js v2.0.2
 doc/html-templates/js/bootstrap-dropdown.js: * bootstrap-dropdown.js
 v2.0.2
 doc/html-templates/js/bootstrap.js: * bootstrap-transition.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-alert.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-button.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-carousel.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-collapse.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-dropdown.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-modal.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-tooltip.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-popover.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-scrollspy.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-tab.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-typeahead.js v2.1.1
 doc/html-templates/js/bootstrap.js: * bootstrap-affix.js v2.1.1
 doc/html-templates/dashboard.html:<script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/dashboard.html:<script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/version.html:    <script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/version.html:    <script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/ticket.html:<script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/ticket.html:<script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/product.html:    <script type="text/javascript" src="js
 /bootstrap-dropdown.js"></script>
 doc/html-templates/product.html:    <script type="text/javascript" src="js
 /bootstrap-button.js"></script>
 doc/html-templates/product.html:    <script type="text/javascript" src="js
 /bootstrap-modal.js"></script>
 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/220#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker