[GitHub] [calcite] amaliujia commented on a change in pull request #2411: Add generic info to Map & Array annotation

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #2411:
URL: https://github.com/apache/calcite/pull/2411#discussion_r639136087



##########
File path: core/src/main/java/org/apache/calcite/adapter/java/Map.java
##########
@@ -16,23 +16,22 @@
  */
 package org.apache.calcite.adapter.java;
 
+import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-import static java.lang.annotation.ElementType.FIELD;
-
 /**
  * Annotation that indicates that a field is a map type.
  */
-@Target({FIELD })
+@Target(ElementType.FIELD)
 @Retention(RetentionPolicy.RUNTIME)
 public @interface Map {
   /** Key type. */
-  Class key();
+  Class<?> key();

Review comment:
       What is changed after having `Class<?>`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org