You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/08 08:08:46 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6345: Storage plugin supports postgrsql

wu-sheng commented on a change in pull request #6345:
URL: https://github.com/apache/skywalking/pull/6345#discussion_r571845115



##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -201,6 +201,18 @@ storage:
     batchEnabled: ${SW_STORAGE_INFLUXDB_BATCH_ENABLED:true}
     fetchTaskLogMaxSize: ${SW_STORAGE_INFLUXDB_FETCH_TASK_LOG_MAX_SIZE:5000} # the max number of fetch task log in a request
     connectionResponseFormat: ${SW_STORAGE_INFLUXDB_CONNECTION_RESPONSE_FORMAT:MSGPACK} # the response format of connection to influxDB, cannot be anything but MSGPACK or JSON.
+  postgresql:

Review comment:
       1. Storage documentation is required to update
   2. `configuration-vocabulary.md` is required to update
   3. `known-oap-backend-dependencies.txt` and `known-oap-backend-dependencies-es7.txt` are required to updated, your CI will fail because of this.
   4. LICENSE in the `dist-material/dist-material` is required to update, and which license is postgresql using?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org