[GitHub] [incubator-mxnet] leezu edited a comment on issue #18091: config/linux.cmake - misleading comment about setting Debug build

[GitBox <gi...@apache.org>]

leezu edited a comment on issue #18091: config/linux.cmake  - misleading comment about setting Debug build
URL: https://github.com/apache/incubator-mxnet/issues/18091#issuecomment-615357495
 
 
   Thanks @anko-intel. This used to work, when we relied on standard cmake `initial-cache` feature to handle our config: `cmake -C ../config.cmake`. 
   
   ```
   -C <initial-cache>
                 Pre-load a script to populate the cache.
   
                 When cmake is first run in an empty build tree, it creates a CMakeCache.txt file and populates  it  with
                 customizable  settings  for  the  project.  This option may be used to specify a file from which to load
                 cache entries before the first pass through the project’s cmake listfiles.  The loaded entries take pri‐
                 ority  over  the  project’s default values.  The given file should be a CMake script containing SET com‐
                 mands that use the CACHE option, not a cache-format file.
   ```
   
   But people were unhappy with the extra typing and we now load the config file automatically if it is present. At the time of loading, the build release type is already set and can't be configured anymore, so we need to remove the `Uncomment the following line to compile with debug information` parts from the config files. You need to invoke cmake with `cmake -DCMAKE_BUILD_TYPE=Debug` instead.
   
   Would you like to open a PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services