You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/08 08:13:38 UTC
[GitHub] [nifi] pvillard31 commented on a change in pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
pvillard31 commented on a change in pull request #5135:
URL: https://github.com/apache/nifi/pull/5135#discussion_r647215118
##########
File path: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
##########
@@ -51,6 +51,10 @@ private BigQueryAttributes() {
+ "the job. If the number of bad records exceeds this value, an invalid error is returned in the job result. By default "
+ "no bad record is ignored.";
+ public static final String DESIGNATE_PROJECT_ID_ATTR = "bq.designate.project.id";
+ public static final String DESIGNATE_PROJECT_ID_DESC = "Sets the designate project id that BigqQuery can use current project resource to "
+ + "manipulate the designate proejct.";
Review comment:
```suggestion
+ "manipulate the designate project.";
```
##########
File path: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/BigQueryAttributes.java
##########
@@ -51,6 +51,10 @@ private BigQueryAttributes() {
+ "the job. If the number of bad records exceeds this value, an invalid error is returned in the job result. By default "
+ "no bad record is ignored.";
+ public static final String DESIGNATE_PROJECT_ID_ATTR = "bq.designate.project.id";
+ public static final String DESIGNATE_PROJECT_ID_DESC = "Sets the designate project id that BigqQuery can use current project resource to "
Review comment:
```suggestion
public static final String DESIGNATE_PROJECT_ID_DESC = "Sets the designate project id that BigQuery can use current project resource to "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org