You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shiro.apache.org by "marcanpilami (via GitHub)" <gi...@apache.org> on 2024/04/30 13:20:38 UTC

[I] [Bug] Wrong jakarta OSGi imports in 2.0.1-SNAPSHOT [shiro]

marcanpilami opened a new issue, #1449:
URL: https://github.com/apache/shiro/issues/1449

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/shiro/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Environment
   
   Apache Felix, OpenJDK 11 or 21
   
   ### Shiro version
   
   2.0.1-SNAPHOT (built by myself) 
   
   ### What was the actual outcome?
   
   Cannot start the shiro-web bundle. This is a follow-up to #1324 (with a few comments, including a discussion on possible fixes).
   
   The 1324 fix seems to be incomplete: it replaces the javax namespace by a jakarta one inside the manifest, but without changing the version of the import. 
   
   For example, the normal package imports `javax.annotation.security;version="[1.3,2)"`. The fix for the jakarta version just renames it to `jakarta.annotation.security;version="[1.3,2)"`.
   
   However, Jakarta never released a 1.3.x bundle containing jakarta.* package - they only released a transition bundle containing javax.* packages. The first version of jakarta.annotations-api containing a jakarta.* package is 2.0.0. 
   
   So we need to change the version, not only the imports. I do not know what shade is able to do here - we may have to add a Maven profile to change the dependencies. 
   
   ### What was the expected outcome?
   
   The bundle starts.
   
   ### How to reproduce
   
   Just try to start it in any OSGi container like Karaf.
   
   ### Debug logs
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org


Re: [I] [Bug] Wrong jakarta OSGi imports in 2.0.1-SNAPSHOT [shiro]

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on issue #1449:
URL: https://github.com/apache/shiro/issues/1449#issuecomment-2089186404

   Is there a proper way to just use `version 1.3 or above` in OSGi? Or `1.3 or 2 or above`
   So we wouldn't have to "fix" a particular version unnecessarily?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org


Re: [I] [Bug] Wrong jakarta OSGi imports in main branch [shiro]

Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on issue #1449:
URL: https://github.com/apache/shiro/issues/1449#issuecomment-2089619571

   I'm playing with the shade maven plugin to make it work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org