[GitHub] merlimat commented on issue #1020: Inject system-env variables to pulsar configuration

[GitBox <gi...@apache.org>]

merlimat commented on issue #1020: Inject system-env variables to pulsar configuration
URL: https://github.com/apache/incubator-pulsar/pull/1020#issuecomment-354712552
 
 
   I think it becomes a bit tricky, because if you want to configure some options through env variables, you might as well need to configure them all. 
   
   For example, what happens if the variable is not defined in 
   
   ```shell
   webServicePort=${webServicePort}
   ```
   
   I think that falling back to default should be the best option. 
   
   For updating the config file through environment variables, there is already a tool in  [docker/scripts/apply-config-from-env.py](https://github.com/apache/incubator-pulsar/blob/master/docker/scripts/apply-config-from-env.py), that updates the config files replacing the variables that are being overwritten through the enviroment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services