You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2011/07/04 12:55:21 UTC
[jira] [Created] (HAMA-410) Support configurable task slot
Support configurable task slot
------------------------------
Key: HAMA-410
URL: https://issues.apache.org/jira/browse/HAMA-410
Project: Hama
Issue Type: New Feature
Components: bsp
Affects Versions: 0.3.0
Reporter: Edward J. Yoon
Assignee: Edward J. Yoon
Fix For: 0.4.0
Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064295#comment-13064295 ]
Hudson commented on HAMA-410:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12486253/HAMA-410_v05.patch
against trunk revision 1143241.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 9 new or modified tests.
core tests +1. The patch passed core unit tests.
Changes : http://builds.apache.org/hudson/job/Hama-Patch/346/changes/
Console output: http://builds.apache.org/hudson/job/Hama-Patch/346/console
This message is automatically generated.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch, HAMA-410_v04.patch, HAMA-410_v05.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059519#comment-13059519 ]
Thomas Jungblut commented on HAMA-410:
--------------------------------------
{quote}LocalBSPRunner should be fixed.{quote}
Okay once again, I can't figure out why this runtime exception occured. Your stacktrace revealed the newInstance call during job submission.
BUT I don't know why it failed? This could only fail if you used an abstract class or interface with job.setBSPClass(XYZ).
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-410:
---------------------------------
Attachment: HAMA-410_v02.patch
This patch fixes localBSPRunner problems and adds a new protected constructor to BSPPeer.
Maven test completes without errors.
{noformat}
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38.273s
[INFO] Finished at: Mon Jul 04 19:29:30 CEST 2011
[INFO] Final Memory: 19M/235M
[INFO] ------------------------------------------------------------------------
{noformat}
Watchout this patch was generated by Subclipse under windows, so there may be CR's.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059405#comment-13059405 ]
Edward J. Yoon commented on HAMA-410:
-------------------------------------
Todo things;
- LocalBSPRunner should be fixed.
- Increase taskCapacity size.
- When scheduling the tasks and launching new bspPeer objects, all bspPeers list should be shared to each bspPeer.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-410:
--------------------------------
Status: Patch Available (was: In Progress)
Running patch through hudson.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch, HAMA-410_v04.patch, HAMA-410_v05.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-410:
--------------------------------
Attachment: HAMA-410_v01.patch
This patch moves BSPPeer to child process.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-410:
--------------------------------
Attachment: HAMA-410_v04.patch
re-attach.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch, HAMA-410_v04.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-410:
--------------------------------
Attachment: HAMA-410_v05.patch
Minor changes. Fixes unit tests.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch, HAMA-410_v04.patch, HAMA-410_v05.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064263#comment-13064263 ]
Edward J. Yoon commented on HAMA-410:
-------------------------------------
I'm split this task into sub-tasks. (See HAMA-413)
And, I'll commit this patch.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch, HAMA-410_v04.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059412#comment-13059412 ]
Edward J. Yoon commented on HAMA-410:
-------------------------------------
I don't remember why I use the BSPPeerProtocol exactly :/ (maybe umbilical design?)
Anyway, the performance has improved after removing it.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059652#comment-13059652 ]
Edward J. Yoon commented on HAMA-410:
-------------------------------------
Oh, my configuration fault. Thanks Thomas!
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059650#comment-13059650 ]
Edward J. Yoon commented on HAMA-410:
-------------------------------------
I'm still getting error.
{code}
edward@edward-VirtualBox:~/workspace/hama-trunk$ bin/hama jar hama-examples-0.3.0-incubating-SNAPSHOT.jar pi
java.lang.RuntimeException: java.lang.InstantiationException
at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:115)
at org.apache.hama.bsp.LocalBSPRunner.submitJob(LocalBSPRunner.java:119)
at org.apache.hama.bsp.BSPJobClient.submitJobInternal(BSPJobClient.java:358)
at org.apache.hama.bsp.BSPJob.submit(BSPJob.java:187)
at org.apache.hama.bsp.BSPJob.waitForCompletion(BSPJob.java:194)
at org.apache.hama.examples.PiEstimator.main(PiEstimator.java:150)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:68)
at org.apache.hadoop.util.ProgramDriver.driver(ProgramDriver.java:139)
at org.apache.hama.examples.ExampleDriver.main(ExampleDriver.java:37)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hama.util.RunJar.main(RunJar.java:145)
Caused by: java.lang.InstantiationException
at sun.reflect.InstantiationExceptionConstructorAccessorImpl.newInstance(InstantiationExceptionConstructorAccessorImpl.java:30)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:113)
... 17 more
{code}
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-410:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've tested enough on my 2 rack Hama cluster.
Fixed!!
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch, HAMA-410_v04.patch, HAMA-410_v05.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059683#comment-13059683 ]
Edward J. Yoon commented on HAMA-410:
-------------------------------------
>> The configuration can now be obtained by the bspPeer, which is now our "context" object similar to Hadoop M/R.
+1
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Issue Comment Edited] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon" <ed...@apache.org>.
Thanks Thomas!
Sent from my iPhone
On 2011. 7. 5., at 오전 2:38, "Thomas Jungblut (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059520#comment-13059520 ]
>
> Thomas Jungblut edited comment on HAMA-410 at 7/4/11 5:36 PM:
> --------------------------------------------------------------
>
> This patch fixes localBSPRunner problems and adds a new protected constructor to BSPPeer.
>
> Maven test completes without errors.
> {noformat}
> Tests run: 22, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38.273s
> [INFO] Finished at: Mon Jul 04 19:29:30 CEST 2011
> [INFO] Final Memory: 19M/235M
> [INFO] ------------------------------------------------------------------------
> {noformat}
>
> Watchout this patch was generated by Subclipse under windows, so there may be CR's.
>
> In addition we should privatize some methods in the BSPPeer class. And mark the existing BSPPeer-Interface methods as final.
>
> was (Author: thomas.jungblut):
> This patch fixes localBSPRunner problems and adds a new protected constructor to BSPPeer.
>
> Maven test completes without errors.
> {noformat}
> Tests run: 22, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38.273s
> [INFO] Finished at: Mon Jul 04 19:29:30 CEST 2011
> [INFO] Final Memory: 19M/235M
> [INFO] ------------------------------------------------------------------------
> {noformat}
>
> Watchout this patch was generated by Subclipse under windows, so there may be CR's.
>
>> Support configurable task slot
>> ------------------------------
>>
>> Key: HAMA-410
>> URL: https://issues.apache.org/jira/browse/HAMA-410
>> Project: Hama
>> Issue Type: New Feature
>> Components: bsp
>> Affects Versions: 0.3.0
>> Reporter: Edward J. Yoon
>> Assignee: Edward J. Yoon
>> Fix For: 0.4.0
>>
>> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>>
>> Original Estimate: 168h
>> Time Spent: 24h
>> Remaining Estimate: 144h
>>
>> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Issue Comment Edited] (HAMA-410) Support configurable task
slot
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059520#comment-13059520 ]
Thomas Jungblut edited comment on HAMA-410 at 7/4/11 5:36 PM:
--------------------------------------------------------------
This patch fixes localBSPRunner problems and adds a new protected constructor to BSPPeer.
Maven test completes without errors.
{noformat}
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38.273s
[INFO] Finished at: Mon Jul 04 19:29:30 CEST 2011
[INFO] Final Memory: 19M/235M
[INFO] ------------------------------------------------------------------------
{noformat}
Watchout this patch was generated by Subclipse under windows, so there may be CR's.
In addition we should privatize some methods in the BSPPeer class. And mark the existing BSPPeer-Interface methods as final.
was (Author: thomas.jungblut):
This patch fixes localBSPRunner problems and adds a new protected constructor to BSPPeer.
Maven test completes without errors.
{noformat}
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38.273s
[INFO] Finished at: Mon Jul 04 19:29:30 CEST 2011
[INFO] Final Memory: 19M/235M
[INFO] ------------------------------------------------------------------------
{noformat}
Watchout this patch was generated by Subclipse under windows, so there may be CR's.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-410) Support configurable task slot
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059681#comment-13059681 ]
Thomas Jungblut commented on HAMA-410:
--------------------------------------
np.
What do you think about refactoring the BSP class a bit?
I thought about that:
{noformat}
public abstract class BSP {
public void setup(BSPPeer bspPeer) throws IOException, InterruptedException {
}
public abstract void bsp(BSPPeer bspPeer) throws IOException,
KeeperException, InterruptedException;
public void cleanup(BSPPeer bspPeer) throws IOException, InterruptedException {
}
}
{noformat}
I think this is much more readable and better for the user. The first time I had to override setConfiguration I didn't know when it get's really called.
The naming now says that we first call setup, then BSP and afterwards cleanup.
The configuration can now be obtained by the bspPeer, which is now our "context" object similar to Hadoop M/R.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-410) Support configurable task slot
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-410:
--------------------------------
Attachment: HAMA-410_v03.patch
attache my progress.
> Support configurable task slot
> ------------------------------
>
> Key: HAMA-410
> URL: https://issues.apache.org/jira/browse/HAMA-410
> Project: Hama
> Issue Type: New Feature
> Components: bsp
> Affects Versions: 0.3.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.4.0
>
> Attachments: HAMA-410_v01.patch, HAMA-410_v02.patch, HAMA-410_v03.patch
>
> Original Estimate: 168h
> Time Spent: 24h
> Remaining Estimate: 144h
>
> Currently we support only 1 task per GroomServer. The size of task slot should be configurable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira