You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/09/30 17:01:03 UTC

Review Request 62716: Replace auto-generated forwarding code with manual implementations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62716/
-----------------------------------------------------------

Review request for Aurora, Jordan Ly and John Sirois.


Repository: aurora


Description
-------

Somewhat in the same vein as [62623](https://reviews.apache.org/r/62623/), i propose we give in to the brittleness of IDEs and build tools in the face of annotation processors.  I can confidently say i've burned far more time invalidating caches in intellij and gradle to work around this than i would have spent manually maintaining the generated code.

This patch cargo cults the code that was being generated for us.


Diffs
-----

  build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 325d3a14ce26e8c6d70c5440761f18bc93b7b5cd 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 0547b1acf0c1fc09898fe05777f45cbaa169eea7 


Diff: https://reviews.apache.org/r/62716/diff/1/


Testing
-------


Thanks,

Bill Farner

Re: Review Request 62716: Replace auto-generated forwarding code with manual implementations

Posted by John Sirois <js...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62716/#review186789
-----------------------------------------------------------


Ship it!




Ship It!

- John Sirois


On Sept. 30, 2017, 11:01 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62716/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2017, 11:01 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Somewhat in the same vein as [62623](https://reviews.apache.org/r/62623/), i propose we give in to the brittleness of IDEs and build tools in the face of annotation processors.  I can confidently say i've burned far more time invalidating caches in intellij and gradle to work around this than i would have spent manually maintaining the generated code.
> 
> This patch cargo cults the code that was being generated for us.
> 
> 
> Diffs
> -----
> 
>   build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 
>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 325d3a14ce26e8c6d70c5440761f18bc93b7b5cd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 0547b1acf0c1fc09898fe05777f45cbaa169eea7 
> 
> 
> Diff: https://reviews.apache.org/r/62716/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 62716: Replace auto-generated forwarding code with manual implementations

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62716/#review186799
-----------------------------------------------------------


Ship it!




Ship It!

- David McLaughlin


On Sept. 30, 2017, 5:01 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62716/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2017, 5:01 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Somewhat in the same vein as [62623](https://reviews.apache.org/r/62623/), i propose we give in to the brittleness of IDEs and build tools in the face of annotation processors.  I can confidently say i've burned far more time invalidating caches in intellij and gradle to work around this than i would have spent manually maintaining the generated code.
> 
> This patch cargo cults the code that was being generated for us.
> 
> 
> Diffs
> -----
> 
>   build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 
>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 325d3a14ce26e8c6d70c5440761f18bc93b7b5cd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 0547b1acf0c1fc09898fe05777f45cbaa169eea7 
> 
> 
> Diff: https://reviews.apache.org/r/62716/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 62716: Replace auto-generated forwarding code with manual implementations

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62716/#review186788
-----------------------------------------------------------


Ship it!




Master (24d2caf) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 30, 2017, 5:01 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62716/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2017, 5:01 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Somewhat in the same vein as [62623](https://reviews.apache.org/r/62623/), i propose we give in to the brittleness of IDEs and build tools in the face of annotation processors.  I can confidently say i've burned far more time invalidating caches in intellij and gradle to work around this than i would have spent manually maintaining the generated code.
> 
> This patch cargo cults the code that was being generated for us.
> 
> 
> Diffs
> -----
> 
>   build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 
>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 325d3a14ce26e8c6d70c5440761f18bc93b7b5cd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 0547b1acf0c1fc09898fe05777f45cbaa169eea7 
> 
> 
> Diff: https://reviews.apache.org/r/62716/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>