You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 14:05:16 UTC
[GitHub] [flink] ifndef-SleePy opened a new pull request #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
ifndef-SleePy opened a new pull request #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781
## What is the purpose of the change
* This PR reverts the commits of FLINK-16945 and FLINK-14971, because we can't find a simple and clean solution of FLINK-16770.
* We decide to revert the commits which cause the inconsistent state of `CompletedCheckpointStore`. So the releasing could get rid of blocking by this.
## Brief change log
* Reverts commits of https://github.com/apache/flink/pull/11648, https://github.com/apache/flink/pull/11627 and https://github.com/apache/flink/pull/11347
## Verifying this change
* This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781#issuecomment-614694494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160567250",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7606",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ea0d7e853fb1b8f244f5ce756fe07348580cf6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160567250) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781#issuecomment-614694494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160567250",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7606",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ea0d7e853fb1b8f244f5ce756fe07348580cf6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160567250) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781#issuecomment-614676903
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c6ea0d7e853fb1b8f244f5ce756fe07348580cf6 (Thu Apr 16 14:09:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781#issuecomment-614694494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160567250",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7606",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ea0d7e853fb1b8f244f5ce756fe07348580cf6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160567250) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781#issuecomment-615139530
Test failure is unrelated and already fixed on master. Thanks @ifndef-SleePy , merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781#issuecomment-614694494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c6ea0d7e853fb1b8f244f5ce756fe07348580cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ea0d7e853fb1b8f244f5ce756fe07348580cf6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski merged pull request #11781:
[FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11781: [FLINK-16770][checkpointing] Revert commits of FLINK-16945 and FLINK-14971
URL: https://github.com/apache/flink/pull/11781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services