[incubator-doris] branch master updated: [compaction][config] Change default config policy to size_based (#4599)

[mo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 4f7cfee  [compaction][config] Change default config policy to size_based (#4599)
4f7cfee is described below

commit 4f7cfee90893ff1ff0216db09217d75ea308cafc
Author: ZhangYu0123 <67...@users.noreply.github.com>
AuthorDate: Wed Sep 16 15:04:06 2020 +0800

    [compaction][config] Change default config policy to size_based (#4599)
    
    (1) change default compaction config policy to size_based
    (2) change missed version check policy when delete stale rowsets
---
 be/src/common/config.h | 2 +-
 be/src/olap/tablet.cpp | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/be/src/common/config.h b/be/src/common/config.h
index b074c85..f868d78 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -279,7 +279,7 @@ namespace config {
     // num_based policy, the original version of cumulative compaction, cumulative version compaction once.
     // size_based policy, a optimization version of cumulative compaction, targeting the use cases requiring 
     // lower write amplification, trading off read amplification and space amplification.
-    CONF_String(cumulative_compaction_policy, "num_based");
+    CONF_String(cumulative_compaction_policy, "size_based");
 
     // In size_based policy, output rowset of cumulative compaction total disk size exceed this config size, 
     // this rowset will be given to base compaction, unit is m byte.
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index ea84164..df64de6 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -445,6 +445,13 @@ void Tablet::delete_expired_stale_rowset() {
     std::vector<Version> missed_versions;
     calc_missed_versions_unlocked(lastest_delta->end_version(), &missed_versions);
 
+    if (!missed_versions.empty()) {
+        LOG(WARNING) << "tablet:" << full_name() << ", missed version for version:" 
+                    << lastest_delta->end_version();
+        _print_missed_versions(missed_versions);
+        return;
+    }
+
     // do check consistent operation
     auto path_id_iter = path_id_vec.begin();
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org