You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/09/15 05:51:29 UTC
[Bug 58408] New: Add visio schemas to the OOXML jar
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
Bug ID: 58408
Summary: Add visio schemas to the OOXML jar
Product: POI
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: VDGF
Assignee: dev@poi.apache.org
Reporter: dustin@virtualroadside.com
Nick has suggested:
In the short term, I'd suggest we do another full jar for it, and have the key
classes included in the poi-ooxml-schemas jar
Medium term, we should release a full ooxml-schemas 1.2 jar, with the visio and
security bits in.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
--- Comment #7 from virtuald <du...@virtualroadside.com> ---
Jenkins should be happy now, found the exclude setting for the rat check.
As far as adding the security jar to the main jar, it seems like the settings
are different for generating the security jars, namely that noupa/nopvr are set
to true. I'm not an XMLBeans expert, will that setting be ok for the main jars?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
--- Comment #6 from virtuald <du...@virtualroadside.com> ---
Looks like Jenkins didn't like that the xsd doesn't have an apache header on
it. Is there an exclude list for the checker somewhere? That seems more
appropriate.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #5 from Nick Burch <ap...@gagravarr.org> ---
If you're bumping the version number of the ooxml-schemas jar up, please add
the security ones too, so people only need the one big one!
Once everyone's happy with the new jar, it'll also need pushing to Maven
central
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
--- Comment #3 from virtuald <du...@virtualroadside.com> ---
I've added the sonar fixes to that branch. I'll rebase the other branch to use
this too.
The unit tests are part of the main visio integration effort, so I'm not going
to worry about adding those here.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #8 from Dominik Stadler <do...@gmx.at> ---
I think this is basically fixed, further work on refactoring the different
schema-jars should be handled in separate issues.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
--- Comment #1 from virtuald <du...@virtualroadside.com> ---
Ok, I created a private branch with the imported XSD, which ignores the
original advice. :) It seems a bit complicated to create a new jar (and my
ant-fu isn't that great), so instead I elected to bump the ooxml-schemas jar
version, and include the visio.xsd there.
The XSD is difficult to download in a standalone form, so I added that to the
repository. It's copyright/usage notice does not reflect the usage notice on
the website -- should we change it to reflect this?
Patch can be found here: https://github.com/virtuald/poi/tree/xsd
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
virtuald <du...@virtualroadside.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from virtuald <du...@virtualroadside.com> ---
Alright, I'm pushing this into trunk as a first step for integration. Bombs
away?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
--- Comment #2 from Dominik Stadler <do...@gmx.at> ---
Changes look good, please note the two "second-class" sets of build-files in
the folders maven/ and sonar/, I did a quick look and you at least should add
the nex XSDs in sonar/ooxml-schema, can can run a "mvn package" in the
sonar-folder to ensure that the Maven-Build for Sonar still runs fine.
Also check the FAQ at http://poi.apache.org/faq.html#faq-N10025, it explains
how necessary pieces end up in the poi-ooxml-schemas-XX.jar when they are used
in unit-tests. The related build-step is at "compile-ooxml-lite". So it happens
automatically, but only with unit-tests which trigger the related code.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58408] Add visio schemas to the OOXML jar
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58408
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org