You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/05 21:34:20 UTC
[jira] [Commented] (ARTEMIS-770) AMQP: Incorrect or inefficient
transformation of AMQP Messages
[ https://issues.apache.org/jira/browse/ARTEMIS-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550011#comment-15550011 ]
ASF GitHub Bot commented on ARTEMIS-770:
----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/820
ARTEMIS-770 AMQP Message Transformer refactor
Refactor the AMQP Message transformers both for better performance and
also to fix a number of issues with the transformers creating inbound
and outbound messages with incorrectly mapped values or extra data
appended where it should not be.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-770
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #820
----
commit 22eceeb6740f02631de7ae2c553505093149e6b5
Author: Timothy Bish <ta...@gmail.com>
Date: 2016-10-03T18:23:50Z
ARTEMIS-770 AMQP Message Transformer refactor
Refactor the AMQP Message transformers both for better performance and
also to fix a number of issues with the transformers creating inbound
and outbound messages with incorrectly mapped values or extra data
appended where it should not be.
----
> AMQP: Incorrect or inefficient transformation of AMQP Messages
> ---------------------------------------------------------------
>
> Key: ARTEMIS-770
> URL: https://issues.apache.org/jira/browse/ARTEMIS-770
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 1.4.0
> Reporter: Timothy Bish
>
> The AMQP Message Transformations done in the protocol module can at times produces incorrect conversion are append additional data not present in the original AMQP message.
> Some noted issues
> * The Message Format value is not preserved from the original delivery.
> * Message Headers are added to outbound messages where the original message did not have any which adds unnecessary overhead.
> * Message Properties can be added to outbound messages where the original did not have any which adds unnecessary overhead and is illegal as the properties section is immutable in AMQP.
> * Additional Application Properties are applied to outbound messages which are meant to be immutable.
> * Some internal properties from the core message are applied to the Message Annotations unnecessarily adding overhead to the outbound message.
> * The outbound message can contain a body that differs from the inbound version in some cases
> * Object serialization / deserialization is done on types from the incoming message that are wrapped in an AmqpValue instead of falling back to native encoding to preserve the original Message body value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)