You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Stig Rohde Døssing (JIRA)" <ji...@apache.org> on 2017/12/22 16:19:00 UTC
[jira] [Comment Edited] (STORM-2865) KafkaSpout constructor with
KafkaConsumerFactory shoud be public
[ https://issues.apache.org/jira/browse/STORM-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301614#comment-16301614 ]
Stig Rohde Døssing edited comment on STORM-2865 at 12/22/17 4:18 PM:
---------------------------------------------------------------------
I believe this is fixed as of 1.2.0. From 1.2.0 on we will use the KafkaConsumer constructor that doesn't take key/value deserializer parameters, so configure will be called. Compare https://github.com/apache/storm/blob/e296d65fdd17c8f8b1fde966e2d54fdad259a7bc/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/KafkaConsumerFactoryDefault.java#L25 and the 1.1.1 version https://github.com/apache/storm/blob/v1.1.1/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/KafkaConsumerFactoryDefault.java#L25.
We shouldn't need to make KafkaConsumerFactory public.
was (Author: srdo):
I believe this is fixed as of 1.2.0. From 1.2.0 on we will use the KafkaConsumer constructor that doesn't take key/value deserializer parameters, so configure will be called. Compare https://github.com/apache/storm/blob/e296d65fdd17c8f8b1fde966e2d54fdad259a7bc/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/KafkaConsumerFactoryDefault.java#L25 and the 1.1.0 version https://github.com/apache/storm/blob/v1.1.1/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/KafkaConsumerFactoryDefault.java#L25.
We shouldn't need to make KafkaConsumerFactory public.
> KafkaSpout constructor with KafkaConsumerFactory shoud be public
> ----------------------------------------------------------------
>
> Key: STORM-2865
> URL: https://issues.apache.org/jira/browse/STORM-2865
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-kafka-client
> Affects Versions: 2.0.0, 1.x
> Environment: kafka version：0.11
> storm-kafka-client version: 1.1.*
> Reporter: YulongZ
> Priority: Minor
> Fix For: 2.0.0, 1.x
>
>
> When we use custom implement of interface "Deserializer"，KafkaSpout constructor can only use class "KafkaConsumerFactoryDefault"，the method “configure” of Interface “Deserializer” will not be called。
> We need change the "KafkaSpout" constructor with "KafkaConsumerFactory" to be public, so we can create custom custom implement of interface "KafkaConsumerFactory".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)