You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2015/11/10 00:44:50 UTC
[GitHub] cordova-ios pull request: CB-9883
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-ios/pull/179
CB-9883
Also remove the wk-webview bridge as the plugin itself simply clobbers cordova.exec now.
1 Bridge! You shall not pass!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-ios CB-9883
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #179
----
commit 21a71fe89ffe575d1b70ce51aa9957777ac23f17
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-11-07T01:53:29Z
Removed wk-webview exec and some linting
commit ccf936dc50977834e1744f383f8040c19e561ba9
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-11-07T02:01:37Z
rebuild cordova.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by chaffeqa <gi...@git.apache.org>.
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155768503
That looks great to me! honestly i dont know how i felt about the idea of dynamically injecting a script... call me old school ;)
Thanks guys a ton for all the hard work on this platform! super appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155253981
It's the Bridge of IFrame-Dûm! Good work Olórin of the Cabbages Purple
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by chaffeqa <gi...@git.apache.org>.
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155608082
I don't know if this was the path intended, but the new changes break the falling back to UIWebView since simply including the WKWebview clobbers `cordova.exec` (and the browser proceeds to barf on a non-existent object on `window.webkit.messageHandler` when running via the UIWebView)
Understandable if this is simply a move away from falling back to UIWebView, but my understanding was that you would still gracefully degrade support to UIWebView (for instance if iOS 8 and not using local webserver)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage closed the pull request at:
https://github.com/apache/cordova-ios/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155689767
I'll fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155613091
Good point, didn't think of that scenario. Ideally each WebView engine, when activated, should inject its own bridge. This would solve this scenario.
We could do this for the WKWebViewEngine plugin -- when it is activated, read the .js file and inject it. The UIWebViewEngine (private) plugin could do it as well in the same manner but we would have to remove the .js from cordova-js-src folder (which is aggregated by cordova-js to create cordova.js) and leave this as a concern for the platform itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155692488
Is this sufficient in the wkwebview plugin?
```
if(window.webkit && window.webkit.messageHandler) {
module.exports = iOSExec;
}
else {
// this will end up clobbering cordova.exec with cordova.exec
// a special case for falling back to UIWebView
module.exports = cordova.exec;
}
```
It will prevent the clobber in this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155847309
Are you able to verify this works @chaffeqa?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org