[GitHub] [tvm] zxybazh commented on a diff in pull request #15466: [Dlight] Fix Customized Dynamic Shape Sampling

["zxybazh (via GitHub)" <gi...@apache.org>]

zxybazh commented on code in PR #15466:
URL: https://github.com/apache/tvm/pull/15466#discussion_r1283486111


##########
python/tvm/dlight/benchmark/utils.py:
##########
@@ -110,6 +119,11 @@ def default_dym_var_sample_func(dym_var_dict: Dict[str, str]) -> Dict[str, int]:
     ----------
     dym_var_dict : Dict[str, str]
         Dynamic shape variable dictionary, e.g., {"n": "int32", "m": "int32"}

Review Comment:
   I don't think so, the data types I've seen are only `int32` and `int64`. Given this is part of the input shapes, it's expected to be integer so I think it also makes sense if we just remove the data type annotation and only use a set to store the variables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org