You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/24 14:27:41 UTC
[GitHub] [spark] WeichenXu123 commented on a change in pull request #25245:
[SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0
WeichenXu123 commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0
URL: https://github.com/apache/spark/pull/25245#discussion_r306840809
##########
File path: mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
##########
@@ -98,3 +103,163 @@ private[image] class ImageFileFormat extends FileFormat with DataSourceRegister
}
}
}
+
+object ImageFileFormat {
Review comment:
Similar to `BinaryFileFormat`, sometimes user may want to get schema by `ImageFileFormat.schema`, so that keep it public is useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org