You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/02/20 23:49:11 UTC
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12541
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
IMPALA-8233: Do not re-download Ranger if it is already downloaded
This patch updates the bootstrap_toolchain.py to not re-download Ranger
if it is already downloaded.
Testing: Manually tested it by running the boolstrap_toolchain.py.
Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
---
M bin/bootstrap_toolchain.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/12541/1
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 1:
(1 comment)
Glad that ranger is coming :-)
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py@423
PS1, Line 423: if os.path.isdir(pkg_directory): return
I think a comment here would be good, I was confused by the 'isdir' call, does that mean it is sometimes a file?
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:02:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3813/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:08:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:08:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2186/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 00:32:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
IMPALA-8233: Do not re-download Ranger if it is already downloaded
This patch updates the bootstrap_toolchain.py to not re-download Ranger
if it is already downloaded.
Testing: Manually tested it by running the boolstrap_toolchain.py.
Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
---
M bin/bootstrap_toolchain.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/12541/3
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 21:25:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py@425
PS1, Line 425: if not version:
: raise Exception("Could not find version for Ranger in environment var {0}"
: .format(env_var_version))
While you're here, do you want to move this to between line 421 and 422, so it's closer?
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 16:54:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Carry Phil's +2.
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py@423
PS1, Line 423: if not version:
> I think a comment here would be good, I was confused by the 'isdir' call, d
I thought it was already pretty clear from the variable name "pkg_directory" :) os.path.isdir will return False if a file already exists. I'll add a comment, though. Done.
http://gerrit.cloudera.org:8080/#/c/12541/1/bin/bootstrap_toolchain.py@425
PS1, Line 425: .format(env_var_version))
: pkg_directory = "{0}/ranger-{1}-admin".format(toolchain_root, version)
: if os.path.isdir(pkg_directory): return
> While you're here, do you want to move this to between line 421 and 422, so
Done
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:07:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2198/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:50:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8233: Do not re-download Ranger if it is already downloaded
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12541 )
Change subject: IMPALA-8233: Do not re-download Ranger if it is already downloaded
......................................................................
IMPALA-8233: Do not re-download Ranger if it is already downloaded
This patch updates the bootstrap_toolchain.py to not re-download Ranger
if it is already downloaded.
Testing: Manually tested it by running the boolstrap_toolchain.py.
Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Reviewed-on: http://gerrit.cloudera.org:8080/12541
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec3b200bda11d00bba6a250461b37c599d8d1adf
Gerrit-Change-Number: 12541
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>