You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/28 12:10:46 UTC

[GitHub] gglanzani commented on issue #4708: [AIRFLOW-3888] HA for metastore connection

gglanzani commented on issue #4708: [AIRFLOW-3888] HA for metastore connection
URL: https://github.com/apache/airflow/pull/4708#issuecomment-468250059
 
 
   @GuzikJakub In principle LGTM, I've requested some changes to make the code easier (to understand) and for logging purposes.
   
   It would be nice to add a test (possibly connecting to a port where nothing is listening?).
   
   @Fokko what's your opinion on the test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services