[GitHub] [cordova-android] breautek commented on issue #849: Fix: Cordova requirements consider the android-targetSdkVersion

[GitBox <gi...@apache.org>]

breautek commented on issue #849: Fix: Cordova requirements consider the android-targetSdkVersion
URL: https://github.com/apache/cordova-android/pull/849#issuecomment-543706010
 
 
   `There is also a possibility they set the gradle.properties file.`
   
   The original code did look at a `.properties` file, and this code continues to do so. I treat the value in there as the "minimum target sdk". This might be a little confusing when there is a min sdk option, but at the same time, google is going to disallow any apps with a target less than 28 anyway.
   
   > the value can also be passed in via Command Line argument
   
   I was not aware of this, and if this is the case, I'm fairly confident current master wouldn't work either as the original code never accepted any parameters nor looked at command line args. But if this is the case, I think it's probably best to address this in this PR as well and I'll add commits accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org