[GitHub] [lucene] thecoop commented on a diff in pull request #11942: Ensure collections are properly sized on creation

[GitBox <gi...@apache.org>]

thecoop commented on code in PR #11942:
URL: https://github.com/apache/lucene/pull/11942#discussion_r1030556441


##########
lucene/analysis/common/src/java/org/apache/lucene/analysis/custom/CustomAnalyzer.java:
##########
@@ -594,11 +589,9 @@ public CustomAnalyzer build() {
     }
 
     private Map<String, String> applyDefaultParams(Map<String, String> map) {
-      if (defaultMatchVersion.get() != null
-          && !map.containsKey(AbstractAnalysisFactory.LUCENE_MATCH_VERSION_PARAM)) {
-        map.put(
-            AbstractAnalysisFactory.LUCENE_MATCH_VERSION_PARAM,
-            defaultMatchVersion.get().toString());
+      Version v;

Review Comment:
   Ah yes, good spot



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org